[PR #773] [CLOSED] End playbar continuing when client is closed #1027

Closed
opened 2026-02-28 14:54:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/773
Author: @Hwatwasthat
Created: 3/28/2021
Status: Closed

Base: masterHead: master


📝 Commits (10+)

  • 9d2126b crossterm updated
  • 01eb7bf crossterm updated, removed write import
  • ecb24b5 crossterm updated, removed write import
  • cb65781 Correctly handle loss of playback context
  • f88ca3e Merge remote-tracking branch 'upstream/master'
  • c3f331b End playback when client closes
  • 10bfe55 reverted previous change
  • 51a0f7f Provided a pretty print for reserved keys
  • 1bf6697 Updated check_reserved_keys
  • e97f499 Ran cargo fmt

📊 Changes

5 files changed (+82 additions, -84 deletions)

View changed files

📝 src/handlers/search_results.rs (+2 -4)
📝 src/handlers/track_table.rs (+16 -30)
📝 src/network.rs (+11 -11)
📝 src/ui/mod.rs (+32 -30)
📝 src/user_config.rs (+21 -9)

📄 Description

Relevant to #576. Have just updated as suggested in that, setting the playback context to none. Has dragged some commits in from an earlier pull request that was merged, not sure why.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/773 **Author:** [@Hwatwasthat](https://github.com/Hwatwasthat) **Created:** 3/28/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`9d2126b`](https://github.com/Rigellute/spotify-tui/commit/9d2126bab8912a75c8fbe3cb3a37e1f9a926d401) crossterm updated - [`01eb7bf`](https://github.com/Rigellute/spotify-tui/commit/01eb7bf756a8f6416ab5a602edd46decb7cef5c5) crossterm updated, removed write import - [`ecb24b5`](https://github.com/Rigellute/spotify-tui/commit/ecb24b5e296a21c5b2cfb957079d7b8cfd7f3c8e) crossterm updated, removed write import - [`cb65781`](https://github.com/Rigellute/spotify-tui/commit/cb6578174689d726238f796604254b23ab21500d) Correctly handle loss of playback context - [`f88ca3e`](https://github.com/Rigellute/spotify-tui/commit/f88ca3e3bfaa7ff3a57b730eb8dfda0bbb203830) Merge remote-tracking branch 'upstream/master' - [`c3f331b`](https://github.com/Rigellute/spotify-tui/commit/c3f331b5f69c64bd9f2e179371d74d8651c5e81c) End playback when client closes - [`10bfe55`](https://github.com/Rigellute/spotify-tui/commit/10bfe5512da54b741f9b4e1efabd0dcc5f499749) reverted previous change - [`51a0f7f`](https://github.com/Rigellute/spotify-tui/commit/51a0f7fbfe5124152e27c03c13833c649667eb66) Provided a pretty print for reserved keys - [`1bf6697`](https://github.com/Rigellute/spotify-tui/commit/1bf66972af1b63801554782f69873f7863fb0e1f) Updated check_reserved_keys - [`e97f499`](https://github.com/Rigellute/spotify-tui/commit/e97f499a0b8f0ec68bd66f1f8cc4951cd82fa5ef) Ran cargo fmt ### 📊 Changes **5 files changed** (+82 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/search_results.rs` (+2 -4) 📝 `src/handlers/track_table.rs` (+16 -30) 📝 `src/network.rs` (+11 -11) 📝 `src/ui/mod.rs` (+32 -30) 📝 `src/user_config.rs` (+21 -9) </details> ### 📄 Description Relevant to [#576](https://github.com/Rigellute/spotify-tui/issues/576). Have just updated as suggested in that, setting the playback context to none. Has dragged some commits in from an earlier pull request that was merged, not sure why. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:54:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#1027
No description provided.