[PR #742] [MERGED] Replace black and white default colors with reset. #1009

New issue

Closed

opened 2026-02-28 14:54:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:54:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/742
Author: @Jesse-Bakker
Created: 2/22/2021
Status: ✅ Merged
Merged: 2/27/2021
Merged by: @Rigellute

Base: master ← Head: default_colors

📝 Commits (1)

a49984d Replace black and white default colors with reset.

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/user_config.rs (+4 -4)

📄 Description

Previously, text would be white, which is not visible on bright color
schemes. The color for non-highlighted text now uses the default
foreground color of the users terminal emulator, making it visible in
any theme. The only visual change in dark color schemes is that the
playbar text might go from black to white, depending on the users
terminal emulator (some terminal emulators swap fore- and background
colors on a colored background depending on the background color; this
is IMO the correct behavior anyway).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/742 **Author:** [@Jesse-Bakker](https://github.com/Jesse-Bakker) **Created:** 2/22/2021 **Status:** ✅ Merged **Merged:** 2/27/2021 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `default_colors` --- ### 📝 Commits (1) - [`a49984d`](https://github.com/Rigellute/spotify-tui/commit/a49984d0fe7a9bbd79722c221f33e9c19203da0f) Replace black and white default colors with reset. ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/user_config.rs` (+4 -4) </details> ### 📄 Description Previously, text would be white, which is not visible on bright color schemes. The color for non-highlighted text now uses the default foreground color of the users terminal emulator, making it visible in any theme. The only visual change in dark color schemes is that the playbar text might go from black to white, depending on the users terminal emulator (some terminal emulators swap fore- and background colors on a colored background depending on the background color; this is IMO the correct behavior anyway). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>