mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #109] volume up and down in the TUI is slow (yes it's that slow) #980
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#980
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sewnie on GitHub (Jan 17, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/109
To Reproduce
press
+or-in the TUI.Expected behavior
the volume is changed quickly.
Log and backtrace
Additional context
I would like to point out that changing the volume from Spotify's Mobile or Web or Desktop client is very quick, compared to the TUI.
@aome510 commented on GitHub (Jan 17, 2023):
Thanks for creating this issue. I'm well aware of this problem.
As you can see from the logs, currently, the client updates the volume by getting the current value, add/subtract 5%, then make a "set" request. The problem is that it takes time for spotify server to reflect the new change, hence making the update look slow. Pressing
+multiple times only result in one update.I already have some rough ideas to fix this.
@sewnie commented on GitHub (Jan 17, 2023):
i cannot express how thankful i am for your ability to take the time to look into bugs and make such good software.
@sewnie commented on GitHub (Jan 17, 2023):
i like to have my music loud, so setting
volumeto100by default solves this issue for me :D@sewnie commented on GitHub (Feb 22, 2023):
because its slow, updating isn't even checked either, which can prompt the wrong volume increase.
https://user-images.githubusercontent.com/47404953/220662834-9d9d9043-229d-40b2-bee5-50decf07cb7d.mp4
@McKean commented on GitHub (Mar 21, 2023):
@apprehensions you mentioned setting volume to 100 by default solves it, is this already a setting that can be applied or are you requesting this via this issue? I'm all in favor, maybe if there's a way just use the volume which has been set and continue where left of.
@aome510 commented on GitHub (Mar 22, 2023):
I may go back to this issue later this month.
@McKean you can set the default
volumeof the integrateddeviceinapp.tomlgeneral config file: https://github.com/aome510/spotify-player/blob/master/examples/app.toml#L27@sewnie commented on GitHub (Mar 26, 2023):
if a solution hadn't been found, i suggest implementing 'Fake' speed; by changing the audio backend's volume before submitting to the Spotify API that we have changed the volume, which might make users a bit confused but this is a good workaround i believe
@aome510 commented on GitHub (Mar 26, 2023):
Should be better with #171. Lmk if u guys encountered any related issues.
@sewnie commented on GitHub (Mar 26, 2023):
exactly ONE second between me requesting volume change, since this is as slow as everything else, it's pretty good!