mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #100] Add sharing functionality #974
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#974
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @noelpilled on GitHub (Jan 6, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/100
A way to copy a link to both currently playing & currently selected track/album/artist/etc(podcast support?) would be nice. Maybe keybinds or adding the option to the action menu
@sewnie commented on GitHub (Jan 7, 2023):
i suggest only displaying the link as copying it would require support for Wayland, X11, etc.
@aome510 commented on GitHub (Jan 18, 2023):
@apprehensions, @noelpilled can you guys test the changes in https://github.com/aome510/spotify-player/pull/110? The copy-link action should be available for all Spotify items. I only tested on macos. The default
copy_commandon Linux isxsel -ibbut feel free to change it by settingcopy_commandoption inapp.tomlfile. For example,@noelpilled commented on GitHub (Jan 19, 2023):
recently made the switch to nixos & not really in a comfortable place to figure out how to package this myself at the moment so I won’t be able to help :(
@sewnie commented on GitHub (Jan 19, 2023):
@aome510, why did you device to do a copy method via a copy command? why don't you just display the track link and have the terminal handle the copying? anyhoo,
xselshould not be used;xclipshould, as its the most used and well-known C xclipboard program. you should also provide an example for wayland viawl-copy.however, since you said i can test:
tl;dr, it doesn't work for me.
xclipis similar toxselas it takes in stdin as input by default.@aome510 commented on GitHub (Jan 19, 2023):
I found it not trivial in my case to copy display text from the terminal. Not sure if it was because the text is rendered by TUI library but I couldn't just select it like I do normally with terminal text. That said, imo, most people would prefer to have one-step action to achieve the goal instead of displaying the link, trying to copy it with terminal.
Judging from the log, it seems the app couldn't find
xclipfrom your path. Can you specify the full path in theapp.tomlconfig file then try again?@aome510 commented on GitHub (Jan 19, 2023):
I could change it to
xclipfor linux. I'm not too familiar with wayland though@sewnie commented on GitHub (Jan 26, 2023):
It supports simply displaying the link.. Right?
@noelpilled commented on GitHub (Jan 26, 2023):
Curious what the use case for simply displaying the link is? Aren't the strings pretty long?
@aome510 commented on GitHub (Jan 28, 2023):
No, it uses a default command to copy the link to clipboard. Like I mentioned before, I found it nontrivial to display the link and copy to clipboard using my terminal.
@treeshateorcs commented on GitHub (Sep 7, 2023):
i added
to my config, but i still can't copyTrackLink. when i press 5 nothing happens (not even the menu closes)
@aome510 commented on GitHub (Sep 9, 2023):
Can you check if there is any errors in the application's log (in
~/.cache/spotify_player/)?@treeshateorcs commented on GitHub (Sep 9, 2023):
it says
even though wl-copy is in path
edit 1: even if i write the full path to wl-copy (/usr/bin/wl-copy) it says no such file or directory
edit 2: with the same config on macos everything works fine (except s/wl-copy/pbcopy)
@aome510 commented on GitHub (Sep 9, 2023):
interesting, can you provide a complete log as well? I want to make sure that the
copy_commandis correctly configured.@treeshateorcs commented on GitHub (Sep 9, 2023):
@aome510 hmmm, it isn't!
and here's my config
just to make sure it's in the correct place - /home/tho/.config/spotify-player/app.toml
edit 1: okay i've found the culprit
copy_commandshould be at the top level, not atdevice