[PR #921] [MERGED] replace tokio blocking tasks with named threads #923

Closed
opened 2026-03-03 00:01:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/921
Author: @aome510
Created: 2/9/2026
Status: Merged
Merged: 2/9/2026
Merged by: @aome510

Base: masterHead: use-thread


📝 Commits (3)

  • 3dc2134 remove fake track repeat mode
  • e59a16f replace tokio blocking tasks with named threads
  • dadf62a cleanup

📊 Changes

12 files changed (+100 additions, -159 deletions)

View changed files

📝 README.md (+0 -1)
📝 spotify_player/src/cli/client.rs (+23 -11)
📝 spotify_player/src/cli/handlers.rs (+1 -4)
📝 spotify_player/src/client/handlers.rs (+32 -66)
📝 spotify_player/src/client/mod.rs (+0 -1)
📝 spotify_player/src/command.rs (+0 -2)
📝 spotify_player/src/config/keymap.rs (+0 -4)
📝 spotify_player/src/event/mod.rs (+0 -6)
📝 spotify_player/src/main.rs (+38 -52)
📝 spotify_player/src/state/model.rs (+0 -6)
📝 spotify_player/src/ui/page.rs (+5 -1)
📝 spotify_player/src/ui/playback.rs (+1 -5)

📄 Description

This PR also removes fake track repeat mode since librespot already supports it


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/921 **Author:** [@aome510](https://github.com/aome510) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/9/2026 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `use-thread` --- ### 📝 Commits (3) - [`3dc2134`](https://github.com/aome510/spotify-player/commit/3dc21341d9d935f8f0a69a1a255baa9fb8cee492) remove fake track repeat mode - [`e59a16f`](https://github.com/aome510/spotify-player/commit/e59a16f3fc302e9952d10732b3ab7b815c30bc3c) replace tokio blocking tasks with named threads - [`dadf62a`](https://github.com/aome510/spotify-player/commit/dadf62adb0a535afe12c690ca93a0a7b1e6364be) cleanup ### 📊 Changes **12 files changed** (+100 additions, -159 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+0 -1) 📝 `spotify_player/src/cli/client.rs` (+23 -11) 📝 `spotify_player/src/cli/handlers.rs` (+1 -4) 📝 `spotify_player/src/client/handlers.rs` (+32 -66) 📝 `spotify_player/src/client/mod.rs` (+0 -1) 📝 `spotify_player/src/command.rs` (+0 -2) 📝 `spotify_player/src/config/keymap.rs` (+0 -4) 📝 `spotify_player/src/event/mod.rs` (+0 -6) 📝 `spotify_player/src/main.rs` (+38 -52) 📝 `spotify_player/src/state/model.rs` (+0 -6) 📝 `spotify_player/src/ui/page.rs` (+5 -1) 📝 `spotify_player/src/ui/playback.rs` (+1 -5) </details> ### 📄 Description This PR also removes fake track repeat mode since `librespot` already supports it --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:01:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#923
No description provided.