[PR #798] [MERGED] Parameterize SeekForward and SeekBackward commands #884

Closed
opened 2026-03-03 00:01:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/798
Author: @Valkyrja-Design
Created: 8/6/2025
Status: Merged
Merged: 8/31/2025
Merged by: @aome510

Base: masterHead: parameterized-seek


📝 Commits (3)

  • 5a4d315 Parameterize SeekForward and SeekBackward commands
  • d7fcef5 Make command descriptions more precise
  • fc9b7f6 Merge remote-tracking branch 'origin/master' into parameterized-seek

📊 Changes

5 files changed (+24 additions, -12 deletions)

View changed files

📝 README.md (+2 -2)
📝 docs/config.md (+6 -0)
📝 spotify_player/src/command.rs (+8 -4)
📝 spotify_player/src/config/keymap.rs (+2 -2)
📝 spotify_player/src/event/mod.rs (+6 -4)

📄 Description

Resolves #724

They now accept an optional duration parameter to specify the seek duration in seconds. If it is not provided, seek_duration_secs from app.toml is used as the default.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/798 **Author:** [@Valkyrja-Design](https://github.com/Valkyrja-Design) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `parameterized-seek` --- ### 📝 Commits (3) - [`5a4d315`](https://github.com/aome510/spotify-player/commit/5a4d315d74d995fe8b430ece2d5dc76b4e525e28) Parameterize `SeekForward` and `SeekBackward` commands - [`d7fcef5`](https://github.com/aome510/spotify-player/commit/d7fcef5329fab25723e4e55b0db9949b81d8d8ab) Make command descriptions more precise - [`fc9b7f6`](https://github.com/aome510/spotify-player/commit/fc9b7f6ccc47241aac3ef833d816a36d3f4f432b) Merge remote-tracking branch 'origin/master' into parameterized-seek ### 📊 Changes **5 files changed** (+24 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -2) 📝 `docs/config.md` (+6 -0) 📝 `spotify_player/src/command.rs` (+8 -4) 📝 `spotify_player/src/config/keymap.rs` (+2 -2) 📝 `spotify_player/src/event/mod.rs` (+6 -4) </details> ### 📄 Description Resolves #724 They now accept an optional `duration` parameter to specify the seek duration in seconds. If it is not provided, `seek_duration_secs` from `app.toml` is used as the default. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:01:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#884
No description provided.