[PR #794] [MERGED] fix `spotify_player connect --name [...]` and `... get key devices` #880

New issue

Closed

opened 2026-03-03 00:01:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:01:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/794
Author: @KUHLwasStolen
Created: 8/4/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @aome510

Base: master ← Head: devices-cli-fix

📝 Commits (2)

8aba5d4 exchange device() for available_devices() to fix device related CLI
2d26450 Merge branch 'aome510:master' into devices-cli-fix

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 spotify_player/src/cli/client.rs (+2 -2)

📄 Description

As pointed out in #758 the connect command fails when used with --name
This happens because the client.device() method is used to determine the ID of the device and this method always returns [ ].

This pull request exchanges this method for available_devices(), which restores the expected behavior.

I also did this for ... get key devices which used the same method and therefore returned only [ ].

closes #758

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/794 **Author:** [@KUHLwasStolen](https://github.com/KUHLwasStolen) **Created:** 8/4/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `devices-cli-fix` --- ### 📝 Commits (2) - [`8aba5d4`](https://github.com/aome510/spotify-player/commit/8aba5d4ed178685243723756be1439cac3870024) exchange `device()` for `available_devices()` to fix device related CLI - [`2d26450`](https://github.com/aome510/spotify-player/commit/2d264509bdbda1a5e5daaaf541343a510eda34d2) Merge branch 'aome510:master' into devices-cli-fix ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/cli/client.rs` (+2 -2) </details> ### 📄 Description As pointed out in #758 the `connect` command fails when used with `--name` This happens because the `client.device()` method is used to determine the ID of the device and this method always returns `[ ]`. This pull request exchanges this method for `available_devices()`, which restores the expected behavior. I also did this for `... get key devices` which used the same method and therefore returned only `[ ]`. closes #758 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>