starred/spotify-player

Fork 0

mirror of https://github.com/aome510/spotify-player.git synced 2026-04-26 01:15:55 +03:00

[GH-ISSUE #170] dbus failure should concur to not attempt #86

New issue

Closed

opened 2026-03-02 23:44:23 +03:00 by kerem · 9 comments

kerem commented

2026-03-02 23:44:23 +03:00

Owner

Originally created by @sewnie on GitHub (Mar 26, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/170

Log and backtrace

Got a panic: PanicInfo {
    payload: Any { .. },
    message: Some(
        called `Result::unwrap()` on an `Err` value: SendError { .. },
    ),
    location: Location {
        file: "/home/sewn/.local/share/cargo/registry/src/github.com-1ecc6299db9ec823/souvlaki-0.6.0/src/platform/mpris/dbus.rs",
        line: 160,
        col: 53,
    },
    can_unwind: true,
}

After spotify-player realizes there is no dbus daemon running, it should instead simply stop sending requests when there isn't one available, instead of crashing immediately.

Originally created by @sewnie on GitHub (Mar 26, 2023). Original GitHub issue: https://github.com/aome510/spotify-player/issues/170 **Log and backtrace** ``` Got a panic: PanicInfo { payload: Any { .. }, message: Some( called `Result::unwrap()` on an `Err` value: SendError { .. }, ), location: Location { file: "/home/sewn/.local/share/cargo/registry/src/github.com-1ecc6299db9ec823/souvlaki-0.6.0/src/platform/mpris/dbus.rs", line: 160, col: 53, }, can_unwind: true, } ``` After spotify-player realizes there is no dbus daemon running, it should instead simply stop sending requests when there isn't one available, instead of crashing immediately.

kerem

2026-03-02 23:44:23 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-02 23:44:24 +03:00

Author

Owner

@aome510 commented on GitHub (Mar 26, 2023):

Looks like a third-party problem to me. It's kinda annoying sometimes when the third-party library doesn't implement error handling probably and just uses unwrap which results in panicking the whole program.

@aome510 commented on GitHub (Mar 26, 2023): Looks like a third-party problem to me. It's kinda annoying sometimes when the third-party library doesn't implement error handling probably and just uses `unwrap` which results in panicking the whole program.

kerem commented

2026-03-02 23:44:24 +03:00

Author

Owner

@sewnie commented on GitHub (Mar 26, 2023):

Hmm, so its either no dbus support or contact the repository? Damn

@sewnie commented on GitHub (Mar 26, 2023): Hmm, so its either no dbus support or contact the repository? Damn

kerem commented

2026-03-02 23:44:24 +03:00

Author

Owner

@aome510 commented on GitHub (Mar 26, 2023):

wdym by no dbus support? I thought the dbus still works fine. IIUC from the issue description, this issue seems to happen when the DBUS dies unexpectedly or something, which should happen rarely.

@aome510 commented on GitHub (Mar 26, 2023): wdym by no dbus support? I thought the `dbus` still works fine. IIUC from the issue description, this issue seems to happen when the DBUS dies unexpectedly or something, which should happen rarely.

kerem commented

2026-03-02 23:44:25 +03:00

Author

Owner

@sewnie commented on GitHub (Mar 26, 2023):

I had no dbus session. And spotify-player was built with the features that depend on Spotify, such as mpris and notify.

@sewnie commented on GitHub (Mar 26, 2023): I had no dbus session. And spotify-player was built with the features that depend on Spotify, such as mpris and notify.

kerem commented

2026-03-02 23:44:25 +03:00

Author

Owner

@aome510 commented on GitHub (Mar 26, 2023):

Wait, it used to work fine for you right? Like the notify and media-control feature. I'm not familiar with dbus, so I don't know how you have no dbus session.

@aome510 commented on GitHub (Mar 26, 2023): Wait, it used to work fine for you right? Like the `notify` and `media-control` feature. I'm not familiar with `dbus`, so I don't know how you have no dbus session.

kerem commented

2026-03-02 23:44:25 +03:00

Author

Owner

@aome510 commented on GitHub (Mar 26, 2023):

FYI, spotify_player with notify and media-control still works for me on my other Ubuntu machine.

@aome510 commented on GitHub (Mar 26, 2023): FYI, `spotify_player` with `notify` and `media-control` still works for me on my other Ubuntu machine.

kerem commented

2026-03-02 23:44:25 +03:00

Author

Owner

@sewnie commented on GitHub (Mar 26, 2023):

I had no dbus session.

One would revoke all possible starting sessions, a way to do this is to unset the DBUS environmental variables.

@sewnie commented on GitHub (Mar 26, 2023): > I had no dbus session. One would revoke all possible starting sessions, a way to do this is to unset the DBUS environmental variables.

kerem commented

2026-03-02 23:44:25 +03:00

Author

Owner

@Sinono3 commented on GitHub (Jan 5, 2024):

This was just fixed in the latest version of Souvlaki. If dbus was not detected when attaching the media controls, it will return an error.

@Sinono3 commented on GitHub (Jan 5, 2024): This was just fixed in the latest version of Souvlaki. If dbus was not detected when attaching the media controls, it will return an error.

kerem commented

2026-03-02 23:44:25 +03:00

Author

Owner

@sewnie commented on GitHub (Jan 6, 2024):

yay htanks

@sewnie commented on GitHub (Jan 6, 2024): yay htanks

kerem referenced this issue

2026-03-14 12:43:39 +03:00

[GH-ISSUE #86] what media control suppose to do? #965