mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #687] Fixed an issue where the player would get stuck on one song after playing for about an hour or so #840
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#840
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/687
Author: @alexjyong
Created: 3/4/2025
Status: 🔄 Open
Base:
master← Head:revamp-token-refreshing📝 Commits (10+)
c90a758Making this access_token_from_user_client_id refresh if needed888a0d0Update cd.yml3683810Update cd.ymldc37c24Update spotify.rs0b901adUpdate cd.ymlb91cff0logging and token refresh7fc5163.60771deUpdate token.rs080e08bUpdate spotify.rsf38e8efUpdate spotify.rs📊 Changes
1 file changed (+40 additions, -11 deletions)
View changed files
📝
spotify_player/src/client/spotify.rs(+40 -11)📄 Description
Partially fixes https://github.com/aome510/spotify-player/issues/603
Looks like we weren't loading the new auth token into the Session when it got refreshed.
Unfortunately, this doesn't seem to be a complete fix, as I see the issue crop up sometimes, and the current page you are on the UI will have to be manually refreshed when the token expires (i.e. navigating to another page seems to help)
It does however, reduce the frequency when it happens. It seems to be the most stable when you get a long playlist running and let it be for a bit.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.