[PR #658] [MERGED] fix: building with notify only #834

Closed
opened 2026-03-03 00:01:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/658
Author: @dibbel26
Created: 1/6/2025
Status: Merged
Merged: 1/9/2025
Merged by: @aome510

Base: masterHead: fix-notify-track-playback


📝 Commits (1)

  • 357033d fix: building with notify only

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+1 -1)

📄 Description

While (#562) implemented conditional compilation for notify without streaming the used function seems to be deprecated with &track out of scope. Replacing it with Self::notify_new_track(&track, &path)?; fixes the issue.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/658 **Author:** [@dibbel26](https://github.com/dibbel26) **Created:** 1/6/2025 **Status:** ✅ Merged **Merged:** 1/9/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-notify-track-playback` --- ### 📝 Commits (1) - [`357033d`](https://github.com/aome510/spotify-player/commit/357033d9580d7211a3f52f638f3428586a790880) fix: building with notify only ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+1 -1) </details> ### 📄 Description While (#562) implemented conditional compilation for notify without streaming the used function seems to be deprecated with &track out of scope. Replacing it with Self::notify_new_track(&track, &path)?; fixes the issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:01:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#834
No description provided.