[PR #636] [MERGED] Cleanup config::theme codes #826

Closed
opened 2026-03-03 00:00:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/636
Author: @aome510
Created: 12/15/2024
Status: Merged
Merged: 12/15/2024
Merged by: @aome510

Base: masterHead: cleanup-style-codes


📝 Commits (3)

  • 04b3991 don't panic upon no playback
  • 972ca6b remove redundant pub
  • 56454f3 cleanup component style getter implementation

📊 Changes

2 files changed (+235 additions, -215 deletions)

View changed files

📝 spotify_player/src/config/theme.rs (+231 -210)
📝 spotify_player/src/ui/page.rs (+4 -5)

📄 Description

  • avoid panic on lyrics page upon no playback
  • clean up codes in config/theme.rs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/636 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/15/2024 **Status:** ✅ Merged **Merged:** 12/15/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `cleanup-style-codes` --- ### 📝 Commits (3) - [`04b3991`](https://github.com/aome510/spotify-player/commit/04b3991644a51c68f0f370c452e203dff1c31b69) don't panic upon no playback - [`972ca6b`](https://github.com/aome510/spotify-player/commit/972ca6bf9fe9739e0898ee35b72c51ea33c9b457) remove redundant `pub` - [`56454f3`](https://github.com/aome510/spotify-player/commit/56454f39e062cd307c40a34b360925bf6e84098c) cleanup component style getter implementation ### 📊 Changes **2 files changed** (+235 additions, -215 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/config/theme.rs` (+231 -210) 📝 `spotify_player/src/ui/page.rs` (+4 -5) </details> ### 📄 Description - avoid panic on lyrics page upon no playback - clean up codes in `config/theme.rs` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 00:00:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#826
No description provided.