[PR #559] [MERGED] Update layout of library and search pages for vertical aspect ratios #796

New issue

Closed

opened 2026-03-02 23:49:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/559
Author: @juliamertz
Created: 9/4/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @aome510

Base: master ← Head: feat-vertical-layouts

📝 Commits (4)

ebf1d94 feat: change layout on vertical display
561fe29 dynamically size search layout
4a6d23a remove dead code
fdf1888 cleanup

📊 Changes

4 files changed (+102 additions, -26 deletions)

View changed files

📝 spotify_player/src/event/mod.rs (+6 -1)
📝 spotify_player/src/state/ui/mod.rs (+9 -1)
📝 spotify_player/src/ui/mod.rs (+32 -0)
📝 spotify_player/src/ui/page.rs (+55 -24)

📄 Description

I've chosen a columns to rows ratio that works well for me, but I'm not sure if this is the best approach since terminal rendering varies.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/559 **Author:** [@juliamertz](https://github.com/juliamertz) **Created:** 9/4/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `feat-vertical-layouts` --- ### 📝 Commits (4) - [`ebf1d94`](https://github.com/aome510/spotify-player/commit/ebf1d9423d3b2712f5761accee803824e08f477a) feat: change layout on vertical display - [`561fe29`](https://github.com/aome510/spotify-player/commit/561fe291fb7a98f051526ea803df0897551e35a9) dynamically size search layout - [`4a6d23a`](https://github.com/aome510/spotify-player/commit/4a6d23ae2868ac3d2f5501106981fea98062598a) remove dead code - [`fdf1888`](https://github.com/aome510/spotify-player/commit/fdf18881cdfa0eb09982c29dda422a2cae0b0d6e) cleanup ### 📊 Changes **4 files changed** (+102 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/mod.rs` (+6 -1) 📝 `spotify_player/src/state/ui/mod.rs` (+9 -1) 📝 `spotify_player/src/ui/mod.rs` (+32 -0) 📝 `spotify_player/src/ui/page.rs` (+55 -24) </details> ### 📄 Description I've chosen a columns to rows ratio that works well for me, but I'm not sure if this is the best approach since terminal rendering varies. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>