[PR #529] [MERGED] fix #454 overflowing of song title #789

New issue

Closed

opened 2026-03-02 23:49:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/529
Author: @DOD-101
Created: 7/31/2024
Status: ✅ Merged
Merged: 8/4/2024
Merged by: @aome510

Base: master ← Head: fix-454-2024-07-28

📝 Commits (10+)

c662594 Add config options for library section width
6c38580 Add check to config width values
abb8b92 Clean up code and rename config values
7b48c95 Add documentation for new config options
21f5935 Remove error handling code
6780cbe Merge branch 'master' into add-278-2024-06-30
33153b5 skip single selection for artist actions (#507)
ea32a53 show album types in the artist context (#508)
e69394f Fix mismatched arguments (#511)
bde96bd Use BufReader/BufWriter for data from file cache (#510)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 spotify_player/src/ui/playback.rs (+1 -1)

📄 Description

~~This PR needs to be merged after #482~~ resolved

Fix #454 by splitting the metadata text and the "title" text into two
different rects. This means that the title text being cut off to long
won't cause the metadata text to overflow outside the viewport.

This does however mean that the playback_format config option should
no longer contain the {metadata} placeholder.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/529 **Author:** [@DOD-101](https://github.com/DOD-101) **Created:** 7/31/2024 **Status:** ✅ Merged **Merged:** 8/4/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-454-2024-07-28` --- ### 📝 Commits (10+) - [`c662594`](https://github.com/aome510/spotify-player/commit/c6625940e185e2c43cd0b35d9e3d944f8bc15bbd) Add config options for library section width - [`6c38580`](https://github.com/aome510/spotify-player/commit/6c38580ef700910500a45e2fa2f93efa4dbb8816) Add check to config width values - [`abb8b92`](https://github.com/aome510/spotify-player/commit/abb8b92c16e99bdb8bb53bf467e18ff3a4e14a46) Clean up code and rename config values - [`7b48c95`](https://github.com/aome510/spotify-player/commit/7b48c953fc8ae22d16d68d41d7d1ca8752e7ea45) Add documentation for new config options - [`21f5935`](https://github.com/aome510/spotify-player/commit/21f593506bea3c92ec313ed4078cf5f949ed6464) Remove error handling code - [`6780cbe`](https://github.com/aome510/spotify-player/commit/6780cbe62b5bb1589b3c18931b1d7d589f46c2ff) Merge branch 'master' into add-278-2024-06-30 - [`33153b5`](https://github.com/aome510/spotify-player/commit/33153b5268b59968bf795586e8567fb78ddc5182) skip single selection for artist actions (#507) - [`ea32a53`](https://github.com/aome510/spotify-player/commit/ea32a536c8b54217ba81bb0ba3ebfea4e95d93d2) show album types in the artist context (#508) - [`e69394f`](https://github.com/aome510/spotify-player/commit/e69394f008fcbf0aeebb2dc091bb08066973a1bf) Fix mismatched arguments (#511) - [`bde96bd`](https://github.com/aome510/spotify-player/commit/bde96bd35ff5d44e571dc8b194d41fd8191f0b6f) Use BufReader/BufWriter for data from file cache (#510) ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/ui/playback.rs` (+1 -1) </details> ### 📄 Description ~This PR needs to be merged after #482~ resolved Fix #454 by splitting the metadata text and the "title" text into two different rects. This means that the title text being cut off to long won't cause the metadata text to overflow outside the viewport. This does however mean that the `playback_format` config option should no longer contain the `{metadata}` placeholder. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>