[PR #514] [MERGED] Use album id as hash to store album covers #784

New issue

Closed

opened 2026-03-02 23:49:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/514
Author: @leon332157
Created: 7/23/2024
Status: ✅ Merged
Merged: 8/1/2024
Merged by: @aome510

Base: master ← Head: master

📝 Commits (8)

04df374 add blake3 as hash crate
65c0204 add hash util function
bdbd56c use hashed filename as album cover path
622c352 remove blake3 dep
6036da0 add album-id as hash
fe6bdb8 fix format
41cca90 cleanup
16840d9 don't add redundant change

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+7 -5)

📄 Description

Fixes #506

My attempt to address #506, this has been tested working on my windows machine, I do recommend more testing though, because with a small digest size, hash collision could occur. In that case, we could use a multi-folder caching technique.

I'm also new to rust, so hopefully I didn't break anything else :)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/514 **Author:** [@leon332157](https://github.com/leon332157) **Created:** 7/23/2024 **Status:** ✅ Merged **Merged:** 8/1/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (8) - [`04df374`](https://github.com/aome510/spotify-player/commit/04df374db4eee88d0fced7af1c00f82c9f00036f) add blake3 as hash crate - [`65c0204`](https://github.com/aome510/spotify-player/commit/65c020495759d21912d9be53ad468df9237f6625) add hash util function - [`bdbd56c`](https://github.com/aome510/spotify-player/commit/bdbd56cc50d4f917973e304e63ca6675967015bc) use hashed filename as album cover path - [`622c352`](https://github.com/aome510/spotify-player/commit/622c352ceaffccaf6869cbf53b480d82095b8fa0) remove blake3 dep - [`6036da0`](https://github.com/aome510/spotify-player/commit/6036da026c47b628254e2ea9100dedeaf1971d41) add album-id as hash - [`fe6bdb8`](https://github.com/aome510/spotify-player/commit/fe6bdb81333800d2e1d52f84110239bd35ebe366) fix format - [`41cca90`](https://github.com/aome510/spotify-player/commit/41cca90690bdd660f1035f4bab5a15c04e9d4189) cleanup - [`16840d9`](https://github.com/aome510/spotify-player/commit/16840d95617f6d587d4a05bce413060655684eb4) don't add redundant change ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+7 -5) </details> ### 📄 Description Fixes #506 My attempt to address #506, this has been tested working on my windows machine, I do recommend more testing though, because with a small digest size, hash collision could occur. In that case, we could use a multi-folder caching technique. I'm also new to rust, so hopefully I didn't break anything else :) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>