[PR #482] [MERGED] Add ability to adjust window ratios #774

New issue

Closed

opened 2026-03-02 23:49:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/482
Author: @DOD-101
Created: 6/30/2024
Status: ✅ Merged
Merged: 8/2/2024
Merged by: @aome510

Base: master ← Head: add-278-2024-06-30

📝 Commits (10+)

c662594 Add config options for library section width
6c38580 Add check to config width values
abb8b92 Clean up code and rename config values
7b48c95 Add documentation for new config options
21f5935 Remove error handling code
6780cbe Merge branch 'master' into add-278-2024-06-30
33153b5 skip single selection for artist actions (#507)
ea32a53 show album types in the artist context (#508)
e69394f Fix mismatched arguments (#511)
bde96bd Use BufReader/BufWriter for data from file cache (#510)

📊 Changes

5 files changed (+81 additions, -19 deletions)

View changed files

📝 docs/config.md (+25 -6)
📝 examples/app.toml (+5 -2)
📝 spotify_player/src/config/mod.rs (+40 -6)
📝 spotify_player/src/ui/page.rs (+9 -3)
📝 spotify_player/src/ui/playback.rs (+2 -2)

📄 Description

resolve #480

This PR adds the following:

A new layout section to the config which contains options for adjusting the ratios of windows found within the app
Move playback_window_width (now playback_window_height) & playback_window_position to new layout section
Update docs accordingly

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/482 **Author:** [@DOD-101](https://github.com/DOD-101) **Created:** 6/30/2024 **Status:** ✅ Merged **Merged:** 8/2/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-278-2024-06-30` --- ### 📝 Commits (10+) - [`c662594`](https://github.com/aome510/spotify-player/commit/c6625940e185e2c43cd0b35d9e3d944f8bc15bbd) Add config options for library section width - [`6c38580`](https://github.com/aome510/spotify-player/commit/6c38580ef700910500a45e2fa2f93efa4dbb8816) Add check to config width values - [`abb8b92`](https://github.com/aome510/spotify-player/commit/abb8b92c16e99bdb8bb53bf467e18ff3a4e14a46) Clean up code and rename config values - [`7b48c95`](https://github.com/aome510/spotify-player/commit/7b48c953fc8ae22d16d68d41d7d1ca8752e7ea45) Add documentation for new config options - [`21f5935`](https://github.com/aome510/spotify-player/commit/21f593506bea3c92ec313ed4078cf5f949ed6464) Remove error handling code - [`6780cbe`](https://github.com/aome510/spotify-player/commit/6780cbe62b5bb1589b3c18931b1d7d589f46c2ff) Merge branch 'master' into add-278-2024-06-30 - [`33153b5`](https://github.com/aome510/spotify-player/commit/33153b5268b59968bf795586e8567fb78ddc5182) skip single selection for artist actions (#507) - [`ea32a53`](https://github.com/aome510/spotify-player/commit/ea32a536c8b54217ba81bb0ba3ebfea4e95d93d2) show album types in the artist context (#508) - [`e69394f`](https://github.com/aome510/spotify-player/commit/e69394f008fcbf0aeebb2dc091bb08066973a1bf) Fix mismatched arguments (#511) - [`bde96bd`](https://github.com/aome510/spotify-player/commit/bde96bd35ff5d44e571dc8b194d41fd8191f0b6f) Use BufReader/BufWriter for data from file cache (#510) ### 📊 Changes **5 files changed** (+81 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+25 -6) 📝 `examples/app.toml` (+5 -2) 📝 `spotify_player/src/config/mod.rs` (+40 -6) 📝 `spotify_player/src/ui/page.rs` (+9 -3) 📝 `spotify_player/src/ui/playback.rs` (+2 -2) </details> ### 📄 Description resolve #480 This PR adds the following: 1. A new `layout` section to the config which contains options for adjusting the ratios of windows found within the app 2. Move `playback_window_width` (now `playback_window_height`) & `playback_window_position` to new `layout` section 3. Update docs accordingly --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>