[PR #471] [MERGED] Add actions to keymap configuration #769

New issue

Closed

opened 2026-03-02 23:49:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/471
Author: @juliamertz
Created: 6/20/2024
Status: ✅ Merged
Merged: 6/23/2024
Merged by: @aome510

Base: master ← Head: feat-action-binds

📝 Commits (10+)

cef8a4f Merge action types into single enum
27d6b2a Seperate action handler from ActionList
d962c76 Add function to get current context for action
35218c6 Handle action keymaps from config
31264cd Add docs
22564e9 Refactor action context function
ef876a3 Update spotify_player/src/config/keymap.rs
4be78fd fix mistake
ddfae97 add docs to functions
f52f270 fix: filter items before handling action

📊 Changes

10 files changed (+660 additions, -311 deletions)

View changed files

📝 README.md (+23 -4)
📝 docs/config.md (+17 -0)
📝 spotify_player/src/command.rs (+85 -64)
📝 spotify_player/src/config/keymap.rs (+62 -4)
📝 spotify_player/src/event/clipboard.rs (+13 -1)
📝 spotify_player/src/event/mod.rs (+205 -13)
📝 spotify_player/src/event/page.rs (+139 -24)
📝 spotify_player/src/event/popup.rs (+16 -193)
📝 spotify_player/src/event/window.rs (+96 -4)
📝 spotify_player/src/state/ui/popup.rs (+4 -4)

📄 Description

Resolves #428

Since this PR is quite large i split it up into smaller commits to hopefully make it easier to understand.

The AddSelectedItemToQueue command could now be removed and replaced with an action keymap, although this might break some people's configurations.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/471 **Author:** [@juliamertz](https://github.com/juliamertz) **Created:** 6/20/2024 **Status:** ✅ Merged **Merged:** 6/23/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `feat-action-binds` --- ### 📝 Commits (10+) - [`cef8a4f`](https://github.com/aome510/spotify-player/commit/cef8a4f3d5b83377ad7128c42fc60b010bc0b573) Merge action types into single enum - [`27d6b2a`](https://github.com/aome510/spotify-player/commit/27d6b2a61c1b02ff6cc86b2515e7d64a30821a99) Seperate action handler from ActionList - [`d962c76`](https://github.com/aome510/spotify-player/commit/d962c76d449e74272a7648982d929c0767b6daff) Add function to get current context for action - [`35218c6`](https://github.com/aome510/spotify-player/commit/35218c6cdc05e66ee1281994fa9ba754838e126b) Handle action keymaps from config - [`31264cd`](https://github.com/aome510/spotify-player/commit/31264cdabc3e00a513e0f4263238d6275b0f49ad) Add docs - [`22564e9`](https://github.com/aome510/spotify-player/commit/22564e9ee8006e9dc0a1c241f1170e628d3ffed3) Refactor action context function - [`ef876a3`](https://github.com/aome510/spotify-player/commit/ef876a3dd93d6265eba7bbc4f1c3f6f48ba892ed) Update spotify_player/src/config/keymap.rs - [`4be78fd`](https://github.com/aome510/spotify-player/commit/4be78fd5ff5283912a76d3f283418115e80b7da4) fix mistake - [`ddfae97`](https://github.com/aome510/spotify-player/commit/ddfae971b2b53848c1f0611bfe2a1491f7b045e2) add docs to functions - [`f52f270`](https://github.com/aome510/spotify-player/commit/f52f2701c3391b6d5a0f77ef5c7be343447105ff) fix: filter items before handling action ### 📊 Changes **10 files changed** (+660 additions, -311 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+23 -4) 📝 `docs/config.md` (+17 -0) 📝 `spotify_player/src/command.rs` (+85 -64) 📝 `spotify_player/src/config/keymap.rs` (+62 -4) 📝 `spotify_player/src/event/clipboard.rs` (+13 -1) 📝 `spotify_player/src/event/mod.rs` (+205 -13) 📝 `spotify_player/src/event/page.rs` (+139 -24) 📝 `spotify_player/src/event/popup.rs` (+16 -193) 📝 `spotify_player/src/event/window.rs` (+96 -4) 📝 `spotify_player/src/state/ui/popup.rs` (+4 -4) </details> ### 📄 Description Resolves #428 Since this PR is quite large i split it up into smaller commits to hopefully make it easier to understand. The AddSelectedItemToQueue command could now be removed and replaced with an action keymap, although this might break some people's configurations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>