[PR #418] [MERGED] Refactor client request handling module #754

New issue

Closed

opened 2026-03-02 23:49:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/418
Author: @aome510
Created: 4/20/2024
Status: ✅ Merged
Merged: 4/20/2024
Merged by: @aome510

Base: master ← Head: handle-player-events

📝 Commits (6)

6826aa9 move ClientRequest,PlayerRequest to client::request module
679fd62 make Client::spotify private
140203b refactor client request handling codes' comment/documentation
568c920 update playback upon receiving new player event
9482f58 fix clippy no-default-features
7b34443 cleanup

📊 Changes

14 files changed (+380 additions, -452 deletions)

View changed files

📝 spotify_player/src/cli/client.rs (+15 -36)
📝 spotify_player/src/cli/handlers.rs (+2 -1)
📝 spotify_player/src/client/handlers.rs (+6 -7)
📝 spotify_player/src/client/mod.rs (+248 -298)
➕ spotify_player/src/client/request.rs (+68 -0)
📝 spotify_player/src/client/spotify.rs (+12 -12)
📝 spotify_player/src/event/mod.rs (+1 -67)
📝 spotify_player/src/main.rs (+11 -10)
📝 spotify_player/src/media_control.rs (+1 -1)
📝 spotify_player/src/state/model.rs (+2 -3)
📝 spotify_player/src/state/player.rs (+4 -7)
📝 spotify_player/src/streaming.rs (+8 -9)
📝 spotify_player/src/ui/playback.rs (+1 -1)
📝 spotify_player/src/utils.rs (+1 -0)

📄 Description

Resolves #415

Changes

update player's playback state upon receiving new player event from the integrated client
move ClientRequest and PlayerRequest from event module to client::request module
clean up client request handling codes, update comments/documentations

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/418 **Author:** [@aome510](https://github.com/aome510) **Created:** 4/20/2024 **Status:** ✅ Merged **Merged:** 4/20/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `handle-player-events` --- ### 📝 Commits (6) - [`6826aa9`](https://github.com/aome510/spotify-player/commit/6826aa9f4c665037827ac017d45f780beded4ac2) move ClientRequest,PlayerRequest to client::request module - [`679fd62`](https://github.com/aome510/spotify-player/commit/679fd621e21164d344fef5854880d0f8654ba65d) make `Client::spotify` private - [`140203b`](https://github.com/aome510/spotify-player/commit/140203b42dca95042c7c7187f6b0fd49c797109e) refactor client request handling codes' comment/documentation - [`568c920`](https://github.com/aome510/spotify-player/commit/568c920309ad7b094a377a4b9dfdafe519dc6e61) update playback upon receiving new player event - [`9482f58`](https://github.com/aome510/spotify-player/commit/9482f586664bb0f403e4290833f9f19f64e5ecfa) fix clippy no-default-features - [`7b34443`](https://github.com/aome510/spotify-player/commit/7b34443f1958105f62357e62cd666481e855830c) cleanup ### 📊 Changes **14 files changed** (+380 additions, -452 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/cli/client.rs` (+15 -36) 📝 `spotify_player/src/cli/handlers.rs` (+2 -1) 📝 `spotify_player/src/client/handlers.rs` (+6 -7) 📝 `spotify_player/src/client/mod.rs` (+248 -298) ➕ `spotify_player/src/client/request.rs` (+68 -0) 📝 `spotify_player/src/client/spotify.rs` (+12 -12) 📝 `spotify_player/src/event/mod.rs` (+1 -67) 📝 `spotify_player/src/main.rs` (+11 -10) 📝 `spotify_player/src/media_control.rs` (+1 -1) 📝 `spotify_player/src/state/model.rs` (+2 -3) 📝 `spotify_player/src/state/player.rs` (+4 -7) 📝 `spotify_player/src/streaming.rs` (+8 -9) 📝 `spotify_player/src/ui/playback.rs` (+1 -1) 📝 `spotify_player/src/utils.rs` (+1 -0) </details> ### 📄 Description Resolves #415 ## Changes - update player's playback state upon receiving new player event from the integrated client - move `ClientRequest` and `PlayerRequest` from `event` module to `client::request` module - clean up client request handling codes, update comments/documentations --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>