[PR #376] [MERGED] Make Daemon feature imply streaming feature #739

New issue

Closed

opened 2026-03-02 23:49:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/376
Author: @LucasFA
Created: 2/23/2024
Status: ✅ Merged
Merged: 2/25/2024
Merged by: @aome510

Base: master ← Head: rm-runtime-errors

📝 Commits (2)

f0614f7 Streaming/audio-backend feature compile time check
b8274bd Make Daemon feature imply streaming feature

📊 Changes

3 files changed (+23 additions, -5 deletions)

View changed files

📝 spotify_player/Cargo.toml (+1 -1)
📝 spotify_player/src/main.rs (+0 -4)
📝 spotify_player/src/streaming.rs (+22 -0)

📄 Description

Right now launching spotify_player with the daemon CLI flag results in a runtime error if the binary was compiled without the streaming feature. As far as I understand it, I do not see why not just do this. The README says it still indicates that it needs some audio backend but AFAIK there's no way to encode that in the feature system.

Note: stumbled into this for the CI suite. There's tooling (aka cargo hack) that uses feature dependencies to build many options. This would stop compilation of binaries with the daemon feature without the streaming feature, reducing number of possible checks. Also just general less possible binaries.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/376 **Author:** [@LucasFA](https://github.com/LucasFA) **Created:** 2/23/2024 **Status:** ✅ Merged **Merged:** 2/25/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `rm-runtime-errors` --- ### 📝 Commits (2) - [`f0614f7`](https://github.com/aome510/spotify-player/commit/f0614f7c19f3c21a438d897b7939dad064182b52) Streaming/audio-backend feature compile time check - [`b8274bd`](https://github.com/aome510/spotify-player/commit/b8274bd5a445ffe4fc619e94619dde48d0cd5c1a) Make Daemon feature imply streaming feature ### 📊 Changes **3 files changed** (+23 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/Cargo.toml` (+1 -1) 📝 `spotify_player/src/main.rs` (+0 -4) 📝 `spotify_player/src/streaming.rs` (+22 -0) </details> ### 📄 Description Right now launching spotify_player with the `daemon` CLI flag results in a runtime error if the binary was compiled without the streaming feature. As far as I understand it, I do not see why not just do this. The README says it still indicates that it needs _some_ audio backend but AFAIK there's no way to encode that in the feature system. Note: stumbled into this for the CI suite. There's tooling (aka `cargo hack`) that uses feature dependencies to build many options. This would stop compilation of binaries with the daemon feature without the streaming feature, reducing number of possible checks. Also just general less possible binaries. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>