[PR #372] [MERGED] Remove winit from compilation on Linux #738

New issue

Closed

opened 2026-03-02 23:49:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/372
Author: @LucasFA
Created: 2/15/2024
Status: ✅ Merged
Merged: 2/16/2024
Merged by: @aome510

Base: master ← Head: remove-dep

📝 Commits (1)

94f6ceb Remove winit from compilation on Linux

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 spotify_player/Cargo.toml (+4 -1)

📄 Description

Winit is only used in one line in MacOS and Windows, and unused in Linux.

This change improves from-scratch compile times from ~3m 47s to ~3m 25 on my Linux machine, as winit was in the critical chain of compilation.

I attached the output of cargo b --release --timings in case you want to read them. GitHub does not allow uploading HTML files so they're zipped here
timings.zip

(BTW enjoy the vacation!)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/372 **Author:** [@LucasFA](https://github.com/LucasFA) **Created:** 2/15/2024 **Status:** ✅ Merged **Merged:** 2/16/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `remove-dep` --- ### 📝 Commits (1) - [`94f6ceb`](https://github.com/aome510/spotify-player/commit/94f6ceb3ae2ce1e2f4b2985e4d5746f10f2126e9) Remove winit from compilation on Linux ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/Cargo.toml` (+4 -1) </details> ### 📄 Description Winit is only used in one line in MacOS and Windows, and unused in Linux. This change improves from-scratch compile times from ~3m 47s to ~3m 25 on my Linux machine, as `winit` was in the critical chain of compilation. I attached the output of `cargo b --release --timings` in case you want to read them. GitHub does not allow uploading HTML files so they're zipped here [timings.zip](https://github.com/aome510/spotify-player/files/14290010/timings.zip) (BTW enjoy the vacation!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>