[PR #354] [MERGED] Add miscellaneous UI code changes #731

New issue

Closed

opened 2026-03-02 23:49:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/354
Author: @aome510
Created: 2/4/2024
Status: ✅ Merged
Merged: 2/4/2024
Merged by: @aome510

Base: master ← Head: misc-ui-code-changes

📝 Commits (7)

d8240fa cleanup component style getter methods of Theme
77834b4 fix page description's style not applied
b8f6f76 use Layout::{vertical|horizontal} API to replace Layout::default().direction(...).constraints(...)
c20c5f8 replace Constraint::Min with Constraint::Fill
d2c4128 rename render_track_table_window to render_track_table
287329a update constraint APIs to use Fill and Ratio
d498dae update rendering order

📊 Changes

6 files changed (+70 additions, -145 deletions)

View changed files

📝 spotify_player/src/config/theme.rs (+2 -20)
📝 spotify_player/src/ui/mod.rs (+6 -5)
📝 spotify_player/src/ui/page.rs (+27 -54)
📝 spotify_player/src/ui/playback.rs (+23 -39)
📝 spotify_player/src/ui/popup.rs (+10 -25)
📝 spotify_player/src/ui/utils.rs (+2 -2)

📄 Description

clean up getter methods to retrieve a theme's component styles
fix a bug that page description's style is not rendered with the new ratatui version
update API usages for tui::Layout and tui::Constraint
rename render_track_table_window to render_track_table and make it private
update rendering order

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/354 **Author:** [@aome510](https://github.com/aome510) **Created:** 2/4/2024 **Status:** ✅ Merged **Merged:** 2/4/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `misc-ui-code-changes` --- ### 📝 Commits (7) - [`d8240fa`](https://github.com/aome510/spotify-player/commit/d8240fa19cd429f090939d58c25cee5ff9cf0429) cleanup component style getter methods of `Theme` - [`77834b4`](https://github.com/aome510/spotify-player/commit/77834b448379c2872737c59a72a4fcb22b265a5f) fix page description's style not applied - [`b8f6f76`](https://github.com/aome510/spotify-player/commit/b8f6f761d3b5912e6f0149a74d3e2bfc5ba43a32) use `Layout::{vertical|horizontal}` API to replace `Layout::default().direction(...).constraints(...)` - [`c20c5f8`](https://github.com/aome510/spotify-player/commit/c20c5f88619be8f84e835db84b274f09962c4c6e) replace `Constraint::Min` with `Constraint::Fill` - [`d2c4128`](https://github.com/aome510/spotify-player/commit/d2c4128c78c145f1be018f0d42baf6cffb4c2506) rename `render_track_table_window` to `render_track_table` - [`287329a`](https://github.com/aome510/spotify-player/commit/287329a4cd35ae0d9d80bfd547aedd4e82cadb6d) update constraint APIs to use `Fill` and `Ratio` - [`d498dae`](https://github.com/aome510/spotify-player/commit/d498dae04e9b207757330adada29daae18a8652c) update rendering order ### 📊 Changes **6 files changed** (+70 additions, -145 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/config/theme.rs` (+2 -20) 📝 `spotify_player/src/ui/mod.rs` (+6 -5) 📝 `spotify_player/src/ui/page.rs` (+27 -54) 📝 `spotify_player/src/ui/playback.rs` (+23 -39) 📝 `spotify_player/src/ui/popup.rs` (+10 -25) 📝 `spotify_player/src/ui/utils.rs` (+2 -2) </details> ### 📄 Description - clean up getter methods to retrieve a theme's component styles - fix a bug that page description's style is not rendered with the new `ratatui` version - update API usages for `tui::Layout` and `tui::Constraint` - rename `render_track_table_window` to `render_track_table` and make it private - update rendering order --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>