[PR #339] [MERGED] chore: update github actions #722

New issue

Closed

opened 2026-03-02 23:49:32 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:32 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/339
Author: @LucasFA
Created: 1/19/2024
Status: ✅ Merged
Merged: 1/20/2024
Merged by: @aome510

Base: master ← Head: update-ci

📝 Commits (2)

d59d2e0 ci(deps): Update github actions
3885434 Add restore-keys, rustc version to CI cachekey

📊 Changes

2 files changed (+27 additions, -33 deletions)

View changed files

📝 .github/workflows/ci.yml (+23 -29)
📝 .github/workflows/docker.yml (+4 -4)

📄 Description

Summary of changes:

Update several actions to the latest version (actions/checkout, docker/{buildx, login, setup-buildx, build-push-action}
Migrated actions from actions-rs to dtolnay/rust-toolchain. The former has been archived, the latter has become popular with many larger projects. actions-rs/cargo migrated to run steps.
Add one rust beta toolchain to CI testing. I only included Ubuntu, figured once is enough. This can be discarded if you want, really. Just to make sure there are no compiler bugs that would soon become an obstable to building the project.
Add rustc version to actions/cache cache-key, add a restore-keys argument for increased cache hits. Given that target/ is not cached really you can make it hit cache everytime, I think.

I have tested in my own repo the CI and the docker deployment actions.

IMPORTANT NOTES:

the docker/login-action documentation now plain asks, rather than recommends, using a token for access instead of the password. I gather it will still work with a password, though.
The CD workflow breaks when updating either the checkout action or the toolchain action. This results in the ubuntu machines cross compiling (and these are the only affected) to break. I've left this as is, but it may be that the containers are not updated anymore; last update was 2 years ago: link to rustembedded dockerhub page.

Other information: about those warnings in the actions log:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/339 **Author:** [@LucasFA](https://github.com/LucasFA) **Created:** 1/19/2024 **Status:** ✅ Merged **Merged:** 1/20/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `update-ci` --- ### 📝 Commits (2) - [`d59d2e0`](https://github.com/aome510/spotify-player/commit/d59d2e01a33eab49563acbda3aa6171a63887d45) ci(deps): Update github actions - [`3885434`](https://github.com/aome510/spotify-player/commit/388543434f5b595a296aa062e6e97f256eda4415) Add restore-keys, rustc version to CI cachekey ### 📊 Changes **2 files changed** (+27 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+23 -29) 📝 `.github/workflows/docker.yml` (+4 -4) </details> ### 📄 Description Summary of changes: - Update several actions to the latest version (actions/checkout, docker/{buildx, login, setup-buildx, build-push-action} - Migrated actions from actions-rs to dtolnay/rust-toolchain. The former has been archived, the latter has become popular with many larger projects. actions-rs/cargo migrated to run steps. - Add one rust beta toolchain to CI testing. I only included Ubuntu, figured once is enough. This can be discarded if you want, really. Just to make sure there are no compiler bugs that would soon become an obstable to building the project. - Add rustc version to actions/cache cache-key, add a restore-keys argument for increased cache hits. Given that target/ is not cached really you can make it hit cache everytime, I think. I have tested in my own repo the CI and the docker deployment actions. IMPORTANT NOTES: - the docker/login-action documentation now plain asks, rather than recommends, using a token for access instead of the password. I gather it will still work with a password, though. - The CD workflow breaks when updating either the checkout action or the toolchain action. This results in the ubuntu machines cross compiling (and these are the only affected) to break. I've left this as is, but it may be that the containers are not updated anymore; last update was 2 years ago: [link to rustembedded dockerhub page](https://hub.docker.com/r/rustembedded/cross/tags). Other information: about those warnings in the actions log: - https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ - https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>