[PR #319] [MERGED] Fix memory leak issue when rendering images in `iTerm2` #717

New issue

Closed

opened 2026-03-02 23:49:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/319
Author: @aome510
Created: 12/11/2023
Status: ✅ Merged
Merged: 12/11/2023
Merged by: @aome510

Base: master ← Head: fix-memleak-with-image

📝 Commits (3)

c96f000 remove cover_image_refresh_duration_in_ms config option
a5fbf00 only render cover image when needed
accd653 reset skip state before rendering "No playback found" message

📊 Changes

6 files changed (+90 additions, -68 deletions)

View changed files

📝 docs/config.md (+31 -32)
📝 examples/app.toml (+0 -1)
📝 spotify_player/src/config/mod.rs (+0 -5)
📝 spotify_player/src/state/ui/mod.rs (+1 -1)
📝 spotify_player/src/ui/mod.rs (+27 -2)
📝 spotify_player/src/ui/playback.rs (+31 -27)

📄 Description

Resolves #318

Changes

remove cover_image_refresh_duration_in_ms config option
update image rendering logic to only trigger when the state changes (previously render periodically)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/319 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/11/2023 **Status:** ✅ Merged **Merged:** 12/11/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-memleak-with-image` --- ### 📝 Commits (3) - [`c96f000`](https://github.com/aome510/spotify-player/commit/c96f000ef031128737879167705f075b4d41fa45) remove `cover_image_refresh_duration_in_ms` config option - [`a5fbf00`](https://github.com/aome510/spotify-player/commit/a5fbf0081bdb731fb9e01da78091e3822920f9d2) only render cover image when needed - [`accd653`](https://github.com/aome510/spotify-player/commit/accd653591bbc7a800d96d32f7184f28a7a4c6ef) reset `skip` state before rendering "No playback found" message ### 📊 Changes **6 files changed** (+90 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+31 -32) 📝 `examples/app.toml` (+0 -1) 📝 `spotify_player/src/config/mod.rs` (+0 -5) 📝 `spotify_player/src/state/ui/mod.rs` (+1 -1) 📝 `spotify_player/src/ui/mod.rs` (+27 -2) 📝 `spotify_player/src/ui/playback.rs` (+31 -27) </details> ### 📄 Description Resolves #318 ## Changes - remove `cover_image_refresh_duration_in_ms` config option - update image rendering logic to only trigger when the state changes (previously render periodically) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>