mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #276] [MERGED] add explicit tags to track information #702
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#702
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/276
Author: @SebRollen
Created: 10/23/2023
Status: ✅ Merged
Merged: 10/23/2023
Merged by: @aome510
Base:
master← Head:explicit-tags📝 Commits (3)
6483366add explicit tags to track information92eba46use 🅴 instead of (Explicit)2fb2fc4replace E unicode with (E)📊 Changes
3 files changed (+26 additions, -4 deletions)
View changed files
📝
spotify_player/src/state/model.rs(+14 -1)📝
spotify_player/src/ui/page.rs(+7 -2)📝
spotify_player/src/ui/playback.rs(+5 -1)📄 Description
Fixes #96.
Adds
(Explicit)to a track name if Spotify reports it as having explicit lyrics. This can make it easier to know if you're listening to the explicit version or the "radio" version of a song.I originally tried to implement this functionality at the album level, using the
restrictionsfield on the Album API, but theexplicitfield was not populated in any of my tests. This seems to match the behavior of the spotify web interface, were there is no explicit marker at the album level, but there is one at the track level.Question for @braheezy (author of #96) and @aome510: what are your thoughts on modifying the track title by appending the string
(Explicit)? Spotify's web interface obviously handles this a bit differently, adding anEsymbol, but I wasn't sure how to translate that to the spotify_player interface. Another possiblity could be to add another column in the track-list, populating the column withEfor explicit tracks and leaving it blank for non-explicit tracks.Screenshots:
Explicit album track listing:

"Radio" album track listing:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.