[PR #253] [MERGED] Add Mute command #688

New issue

Closed

opened 2026-03-02 23:49:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/253
Author: @catumin
Created: 9/14/2023
Status: ✅ Merged
Merged: 9/22/2023
Merged by: @aome510

Base: master ← Head: mute

📝 Commits (6)

2ea4d79 Add Mute command
c5a550e Turn Mute into a toggle
1bfa73b Resolve clippy/fmt suggestions
8b7d9a0 Add UI for mute
a3930ac simplify ToggleMute logic and handle increase/decrease volume on mute
3f7e488 update readme

📊 Changes

7 files changed (+52 additions, -4 deletions)

View changed files

📝 README.md (+1 -0)
📝 spotify_player/src/client/mod.rs (+21 -1)
📝 spotify_player/src/command.rs (+2 -0)
📝 spotify_player/src/config/keymap.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+4 -0)
📝 spotify_player/src/state/player.rs (+2 -0)
📝 spotify_player/src/ui/playback.rs (+18 -3)

📄 Description

Resolves https://github.com/aome510/spotify-player/issues/243.

Add the ability to immediately set volume to 0% as requested in #243. I bound it to _ since "Shift + -" made sense to me, as it's basically super volume decrease.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/253 **Author:** [@catumin](https://github.com/catumin) **Created:** 9/14/2023 **Status:** ✅ Merged **Merged:** 9/22/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `mute` --- ### 📝 Commits (6) - [`2ea4d79`](https://github.com/aome510/spotify-player/commit/2ea4d7985b41cf250cc6a7c45e361c704fb55d4a) Add Mute command - [`c5a550e`](https://github.com/aome510/spotify-player/commit/c5a550ec6d91e7f3269117622fc6277c679d85da) Turn Mute into a toggle - [`1bfa73b`](https://github.com/aome510/spotify-player/commit/1bfa73b9e0bc6620f0e2aa012c55d48d45914ec2) Resolve clippy/fmt suggestions - [`8b7d9a0`](https://github.com/aome510/spotify-player/commit/8b7d9a0cef10509f48693ff92a29c66e7742abaa) Add UI for mute - [`a3930ac`](https://github.com/aome510/spotify-player/commit/a3930acbca1fb1a77e371b9d11101747e84e407a) simplify `ToggleMute` logic and handle increase/decrease volume on mute - [`3f7e488`](https://github.com/aome510/spotify-player/commit/3f7e4889e6ad3c83e7c57be19c084a8ece781442) update readme ### 📊 Changes **7 files changed** (+52 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `spotify_player/src/client/mod.rs` (+21 -1) 📝 `spotify_player/src/command.rs` (+2 -0) 📝 `spotify_player/src/config/keymap.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+4 -0) 📝 `spotify_player/src/state/player.rs` (+2 -0) 📝 `spotify_player/src/ui/playback.rs` (+18 -3) </details> ### 📄 Description Resolves https://github.com/aome510/spotify-player/issues/243. Add the ability to immediately set volume to 0% as requested in #243. I bound it to _ since "Shift + -" made sense to me, as it's basically super volume decrease. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>