[PR #249] [MERGED] Optimize CLI command runtime #686

New issue

Closed

opened 2026-03-02 23:49:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/249
Author: @aome510
Created: 9/9/2023
Status: ✅ Merged
Merged: 9/9/2023
Merged by: @aome510

Base: master ← Head: optimize-cli-command-runtime

📝 Commits (2)

a6d7cb8 not require CLI handler to wait for client to handle player request
2c93ec3 speed-up get key playback CLI command using cached/buffer state data

📊 Changes

2 files changed (+50 additions, -8 deletions)

View changed files

📝 spotify_player/src/cli/client.rs (+19 -8)
📝 spotify_player/src/state/player.rs (+31 -0)

📄 Description

Resolves #248

optimized runtime for get key playback CLI command
optimized runtime for playback CLI commands

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/249 **Author:** [@aome510](https://github.com/aome510) **Created:** 9/9/2023 **Status:** ✅ Merged **Merged:** 9/9/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `optimize-cli-command-runtime` --- ### 📝 Commits (2) - [`a6d7cb8`](https://github.com/aome510/spotify-player/commit/a6d7cb81029d860f0b750a76d31876ac53732217) not require CLI handler to wait for client to handle player request - [`2c93ec3`](https://github.com/aome510/spotify-player/commit/2c93ec31aaa7892b4b4d41a50b375d1449835d19) speed-up `get key playback` CLI command using cached/buffer state data ### 📊 Changes **2 files changed** (+50 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/cli/client.rs` (+19 -8) 📝 `spotify_player/src/state/player.rs` (+31 -0) </details> ### 📄 Description Resolves #248 - optimized runtime for `get key playback` CLI command - optimized runtime for `playback` CLI commands --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>