[PR #221] [MERGED] Create app.toml with default values if it doesn't exist #671

New issue

Closed

opened 2026-03-02 23:49:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/221
Author: @cobbinma
Created: 7/17/2023
Status: ✅ Merged
Merged: 7/18/2023
Merged by: @aome510

Base: master ← Head: feat/182-create-default-app.toml

📝 Commits (6)

b2c493f feat: 182 create default app.toml
aa9e0e4 refactor: 182 other theme constructors
da64239 docs: 182 update readme with new app config behaviour
535ba4a Update spotify_player/src/state/mod.rs
691da97 refactor: 182 revert config import change from self
2e592f1 refactor: 182 return bool and update comment

📊 Changes

6 files changed (+71 additions, -53 deletions)

View changed files

📝 README.md (+2 -0)
📝 spotify_player/src/config/keymap.rs (+7 -1)
📝 spotify_player/src/config/mod.rs (+37 -12)
📝 spotify_player/src/config/theme.rs (+8 -1)
📝 spotify_player/src/main.rs (+4 -9)
📝 spotify_player/src/state/mod.rs (+13 -30)

📄 Description

If an application configuration file is not found, one will be created with default values in the config directory.

The configs have been refactored to use new constructors instead of default implementations.

closes #182

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/221 **Author:** [@cobbinma](https://github.com/cobbinma) **Created:** 7/17/2023 **Status:** ✅ Merged **Merged:** 7/18/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `feat/182-create-default-app.toml` --- ### 📝 Commits (6) - [`b2c493f`](https://github.com/aome510/spotify-player/commit/b2c493fdbe0551068c59c1fd15dbc57a989e8f04) feat: 182 create default app.toml - [`aa9e0e4`](https://github.com/aome510/spotify-player/commit/aa9e0e4630adc168d7673826d3219758a61b8d7a) refactor: 182 other theme constructors - [`da64239`](https://github.com/aome510/spotify-player/commit/da642399ac6239a650b15cf4f2dd5388bb802bb6) docs: 182 update readme with new app config behaviour - [`535ba4a`](https://github.com/aome510/spotify-player/commit/535ba4ac295f95eef94d4f357970d1002495a0d1) Update spotify_player/src/state/mod.rs - [`691da97`](https://github.com/aome510/spotify-player/commit/691da97d876d3ea0e4a20a664e055d56aeb15b19) refactor: 182 revert config import change from self - [`2e592f1`](https://github.com/aome510/spotify-player/commit/2e592f19511855b27836f527e01224df3281071d) refactor: 182 return bool and update comment ### 📊 Changes **6 files changed** (+71 additions, -53 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -0) 📝 `spotify_player/src/config/keymap.rs` (+7 -1) 📝 `spotify_player/src/config/mod.rs` (+37 -12) 📝 `spotify_player/src/config/theme.rs` (+8 -1) 📝 `spotify_player/src/main.rs` (+4 -9) 📝 `spotify_player/src/state/mod.rs` (+13 -30) </details> ### 📄 Description If an application configuration file is not found, one will be created with default values in the config directory. The configs have been refactored to use `new` constructors instead of default implementations. closes #182 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>