[PR #173] [MERGED] Support selecting an action in action list popup using '0' to '9' #651

New issue

Closed

opened 2026-03-02 23:49:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/173
Author: @aome510
Created: 3/28/2023
Status: ✅ Merged
Merged: 3/28/2023
Merged by: @aome510

Base: master ← Head: add-keymaps-to-actions-menu

📝 Commits (4)

99b491d update execute_copy_command to take reference to config::Command
5a9ab21 move the action handling codes into handle_nth_action function
01c91ad support selecting an action in a popup with key from '0' to '9'
af4ae0a cleanup

📊 Changes

3 files changed (+242 additions, -210 deletions)

View changed files

📝 spotify_player/src/event/popup.rs (+238 -207)
📝 spotify_player/src/state/ui/popup.rs (+1 -1)
📝 spotify_player/src/ui/popup.rs (+3 -2)

📄 Description

Resolves #156

Note: base-10 digit keys are enough for now because the number of actions doesn't exceed 10. However, in the future when we support more actions, this needs to be changed (maybe use hex or bigger radix digits instead).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/173 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/28/2023 **Status:** ✅ Merged **Merged:** 3/28/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-keymaps-to-actions-menu` --- ### 📝 Commits (4) - [`99b491d`](https://github.com/aome510/spotify-player/commit/99b491deee30a0950cb20159eb18df8507d9b45a) update `execute_copy_command` to take reference to `config::Command` - [`5a9ab21`](https://github.com/aome510/spotify-player/commit/5a9ab21fe89b0c47963a26f19a71ff3c5560d38a) move the action handling codes into `handle_nth_action` function - [`01c91ad`](https://github.com/aome510/spotify-player/commit/01c91ade6500ee9bafc9d042c3361230d06047e6) support selecting an action in a popup with key from '0' to '9' - [`af4ae0a`](https://github.com/aome510/spotify-player/commit/af4ae0a8201d718873ed84a5b8a7ba65072c3b43) cleanup ### 📊 Changes **3 files changed** (+242 additions, -210 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/popup.rs` (+238 -207) 📝 `spotify_player/src/state/ui/popup.rs` (+1 -1) 📝 `spotify_player/src/ui/popup.rs` (+3 -2) </details> ### 📄 Description Resolves #156 **Note**: base-10 digit keys are enough for now because the number of actions doesn't exceed 10. However, in the future when we support more actions, this needs to be changed (maybe use hex or bigger radix digits instead). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>