[PR #171] [MERGED] Add buffered playback #650

Closed
opened 2026-03-02 23:49:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/171
Author: @aome510
Created: 3/26/2023
Status: Merged
Merged: 3/26/2023
Merged by: @aome510

Base: masterHead: add-buffered-playback


📝 Commits (3)

  • 8accd03 add buffered playback
  • 143f64a handle buffered playback after transferring playback
  • 7954410 handle buffered playback on new device connection

📊 Changes

5 files changed (+59 additions, -26 deletions)

View changed files

📝 spotify_player/src/client/mod.rs (+38 -5)
📝 spotify_player/src/event/mod.rs (+8 -6)
📝 spotify_player/src/state/model.rs (+3 -1)
📝 spotify_player/src/state/player.rs (+4 -10)
📝 spotify_player/src/ui/playback.rs (+6 -4)

📄 Description

Resolves #109

Implemented a buffered playback state that allows speedup of the feedback of playback metadata update to the user by

  1. assuming metadata update requests always succeed
  2. buffering all the updates

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/171 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/26/2023 **Status:** ✅ Merged **Merged:** 3/26/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-buffered-playback` --- ### 📝 Commits (3) - [`8accd03`](https://github.com/aome510/spotify-player/commit/8accd03a1908236582b57e85dee52406185fd623) add buffered playback - [`143f64a`](https://github.com/aome510/spotify-player/commit/143f64abd6f08384bae631fa74441654b5924b9e) handle buffered playback after transferring playback - [`7954410`](https://github.com/aome510/spotify-player/commit/79544109ca66a5d08876e3ad9364e98ec0052ad1) handle buffered playback on new device connection ### 📊 Changes **5 files changed** (+59 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/mod.rs` (+38 -5) 📝 `spotify_player/src/event/mod.rs` (+8 -6) 📝 `spotify_player/src/state/model.rs` (+3 -1) 📝 `spotify_player/src/state/player.rs` (+4 -10) 📝 `spotify_player/src/ui/playback.rs` (+6 -4) </details> ### 📄 Description Resolves #109 Implemented a buffered playback state that allows speedup of the feedback of playback metadata update to the user by 1. assuming metadata update requests always succeed 2. buffering all the updates --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:49:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#650
No description provided.