[PR #169] [MERGED] Add configuration option for streaming #649

Closed
opened 2026-03-02 23:49:12 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/169
Author: @jesyspa
Created: 3/25/2023
Status: Merged
Merged: 3/26/2023
Merged by: @aome510

Base: masterHead: streaming-in-config


📝 Commits (1)

  • 915ae0a Add configuration option for streaming

📊 Changes

4 files changed (+14 additions, -4 deletions)

View changed files

📝 docs/config.md (+1 -0)
📝 examples/app.toml (+1 -0)
📝 spotify_player/src/config/mod.rs (+6 -0)
📝 spotify_player/src/main.rs (+6 -4)

📄 Description

Allow streaming to be disabled via app.conf using enable_streaming when the streaming feature is used.

I wasn't sure whether enable_streaming or disable_streaming made more sense, I don't have a strong preference so just did the same as enable_media_control.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/169 **Author:** [@jesyspa](https://github.com/jesyspa) **Created:** 3/25/2023 **Status:** ✅ Merged **Merged:** 3/26/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `streaming-in-config` --- ### 📝 Commits (1) - [`915ae0a`](https://github.com/aome510/spotify-player/commit/915ae0aa262276870b1389086b55414f9428b699) Add configuration option for streaming ### 📊 Changes **4 files changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+1 -0) 📝 `examples/app.toml` (+1 -0) 📝 `spotify_player/src/config/mod.rs` (+6 -0) 📝 `spotify_player/src/main.rs` (+6 -4) </details> ### 📄 Description Allow streaming to be disabled via app.conf using `enable_streaming` when the `streaming` feature is used. I wasn't sure whether `enable_streaming` or `disable_streaming` made more sense, I don't have a strong preference so just did the same as `enable_media_control`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:49:12 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#649
No description provided.