[PR #152] [MERGED] Add more UI customizations and refactor UI codes #644

Closed
opened 2026-03-02 23:49:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/152
Author: @aome510
Created: 3/3/2023
Status: Merged
Merged: 3/4/2023
Merged by: @aome510

Base: masterHead: more-ui-customizations


📝 Commits (10+)

  • 608c795 add border_style config option
  • cd3bdbe allow to configure border type
  • 4330297 change construct_block to construct_and_render_block
  • cc3e6df don't wrap the list inside a block
  • 647b754 update the page rendering codes
  • de6ce4f update playback rendering codes to use construct_track_actions
  • a68b1d7 update popup rendering codes to manually render the popup's block
  • a6a60c8 fix compile errors
  • 245c8b8 clean up
  • 5d1a91f fix clippy errors

📊 Changes

6 files changed (+366 additions, -254 deletions)

View changed files

📝 docs/config.md (+4 -0)
📝 spotify_player/src/config/mod.rs (+23 -0)
📝 spotify_player/src/ui/page.rs (+209 -156)
📝 spotify_player/src/ui/playback.rs (+36 -36)
📝 spotify_player/src/ui/popup.rs (+47 -42)
📝 spotify_player/src/ui/utils.rs (+47 -20)

📄 Description

Resolves #128

Changes

  • added border_type and progress_bar_type config options to customize the application's borders and playback progress bar
  • refactored page rendering codes to make them more organized and follow a given structure
  • updated UI codes to force manual rendering blocks (for a window's title and borders)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/152 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/3/2023 **Status:** ✅ Merged **Merged:** 3/4/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `more-ui-customizations` --- ### 📝 Commits (10+) - [`608c795`](https://github.com/aome510/spotify-player/commit/608c7952100331ce8fec03ee116a66df360c3e5a) add `border_style` config option - [`cd3bdbe`](https://github.com/aome510/spotify-player/commit/cd3bdbee5aa27fcd5c29265a68d43d910be5ce6b) allow to configure border type - [`4330297`](https://github.com/aome510/spotify-player/commit/43302978a9d164e03e453074ef48cd2b8595e1be) change `construct_block` to `construct_and_render_block` - [`cc3e6df`](https://github.com/aome510/spotify-player/commit/cc3e6df07e8273a3f35657308502db6bff3262a0) don't wrap the list inside a block - [`647b754`](https://github.com/aome510/spotify-player/commit/647b75469a8d07d405d9d25eb452cf55d2cb97e3) update the page rendering codes - [`de6ce4f`](https://github.com/aome510/spotify-player/commit/de6ce4fe42fbb023cbd9fe98f5224f46fe519215) update playback rendering codes to use `construct_track_actions` - [`a68b1d7`](https://github.com/aome510/spotify-player/commit/a68b1d7df6448b25f2e9a1a91072415516046fdb) update popup rendering codes to manually render the popup's block - [`a6a60c8`](https://github.com/aome510/spotify-player/commit/a6a60c811b83bdda50d6757b8532d4264ef96f64) fix compile errors - [`245c8b8`](https://github.com/aome510/spotify-player/commit/245c8b8af713486da0eb9bcb4f4fef278623b7cf) clean up - [`5d1a91f`](https://github.com/aome510/spotify-player/commit/5d1a91fa26fb39db93eb12796a607c1d71714c80) fix clippy errors ### 📊 Changes **6 files changed** (+366 additions, -254 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+4 -0) 📝 `spotify_player/src/config/mod.rs` (+23 -0) 📝 `spotify_player/src/ui/page.rs` (+209 -156) 📝 `spotify_player/src/ui/playback.rs` (+36 -36) 📝 `spotify_player/src/ui/popup.rs` (+47 -42) 📝 `spotify_player/src/ui/utils.rs` (+47 -20) </details> ### 📄 Description Resolves #128 ## Changes - added `border_type` and `progress_bar_type` config options to customize the application's borders and playback progress bar - refactored page rendering codes to make them more organized and follow a given structure - updated UI codes to force manual rendering blocks (for a window's title and borders) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:49:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#644
No description provided.