[PR #92] [MERGED] Improve radio feature UX #623

Closed
opened 2026-03-02 23:49:05 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/92
Author: @aome510
Created: 12/22/2022
Status: Merged
Merged: 12/23/2022
Merged by: @aome510

Base: masterHead: improve-radio-ux


📝 Commits (10+)

  • 607a872 fix typo in README
  • 5e54354 rename Browse* actions to GoTo* actions
  • 285c951 implement GoToRadio artist popup action in addition to browse action
  • 9cf49db update action's names in README
  • 3b1924b cleanup
  • 322782c add serde_json
  • bac8c58 implement get-radio-tracks API based on librespot's mercury APIs
  • e573d6e add create_new_radio_page helper function
  • 26cb88b add more GoTo*Radio actions and corresponding handlers
  • 44831ac update README

📊 Changes

14 files changed (+186 additions, -121 deletions)

View changed files

📝 Cargo.lock (+3 -2)
📝 README.md (+1 -1)
📝 spotify_player/Cargo.toml (+1 -0)
📝 spotify_player/src/client/mod.rs (+57 -43)
📝 spotify_player/src/client/spotify.rs (+6 -0)
📝 spotify_player/src/command.rs (+18 -8)
📝 spotify_player/src/event/mod.rs (+1 -1)
📝 spotify_player/src/event/page.rs (+1 -0)
📝 spotify_player/src/event/popup.rs (+71 -43)
📝 spotify_player/src/event/window.rs (+7 -3)
📝 spotify_player/src/state/model.rs (+0 -17)
📝 spotify_player/src/state/ui/mod.rs (+11 -1)
📝 spotify_player/src/state/ui/popup.rs (+8 -1)
📝 spotify_player/src/ui/popup.rs (+1 -1)

📄 Description

Changes

  • renamed Browse* actions to GoTo* actions, e.g BrowseAlbum to GoToAlbum
  • added
    • GoToArtistRadio, GoToAlbumRadio actions for track
    • GoToLibraryRadio action for library
    • GoToAlbumRadio, GoToArtistRadio actions for album
  • implemented Spotify-like radio page by using librespot's Mercury APIs, which allows the list of recommended tracks to look similar to what is shown in the official Spotify app and to support radio pages of other Spotify items beside track and artist
  • added a TODO for fixing sorting not working in non-context pages

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/92 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/22/2022 **Status:** ✅ Merged **Merged:** 12/23/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `improve-radio-ux` --- ### 📝 Commits (10+) - [`607a872`](https://github.com/aome510/spotify-player/commit/607a8721d46971503f5a3e82de535064d1bd2be4) fix typo in README - [`5e54354`](https://github.com/aome510/spotify-player/commit/5e54354d0b02df4a0c9dea63d8eb357ba4114416) rename `Browse*` actions to `GoTo*` actions - [`285c951`](https://github.com/aome510/spotify-player/commit/285c9514702e2893fcb697da8ad1840701a9ec6f) implement `GoToRadio` artist popup action in addition to browse action - [`9cf49db`](https://github.com/aome510/spotify-player/commit/9cf49dbfa83ace723bcc4100755eef220f1bc21c) update action's names in README - [`3b1924b`](https://github.com/aome510/spotify-player/commit/3b1924b13db0b1ed500e7f08586cd8b3a2fc6a98) cleanup - [`322782c`](https://github.com/aome510/spotify-player/commit/322782c712b894c7bb2889f702261b44365d338f) add `serde_json` - [`bac8c58`](https://github.com/aome510/spotify-player/commit/bac8c58372216bb83b5b44f4a85fad5b523c99a4) implement get-radio-tracks API based on librespot's mercury APIs - [`e573d6e`](https://github.com/aome510/spotify-player/commit/e573d6e86edde77d73125817298af0305b1f7a52) add `create_new_radio_page` helper function - [`26cb88b`](https://github.com/aome510/spotify-player/commit/26cb88bbf17901c43cb89d8bd12d2379bd98e110) add more `GoTo*Radio` actions and corresponding handlers - [`44831ac`](https://github.com/aome510/spotify-player/commit/44831ac1e391964619ba125ca7c17115550a6e29) update README ### 📊 Changes **14 files changed** (+186 additions, -121 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+3 -2) 📝 `README.md` (+1 -1) 📝 `spotify_player/Cargo.toml` (+1 -0) 📝 `spotify_player/src/client/mod.rs` (+57 -43) 📝 `spotify_player/src/client/spotify.rs` (+6 -0) 📝 `spotify_player/src/command.rs` (+18 -8) 📝 `spotify_player/src/event/mod.rs` (+1 -1) 📝 `spotify_player/src/event/page.rs` (+1 -0) 📝 `spotify_player/src/event/popup.rs` (+71 -43) 📝 `spotify_player/src/event/window.rs` (+7 -3) 📝 `spotify_player/src/state/model.rs` (+0 -17) 📝 `spotify_player/src/state/ui/mod.rs` (+11 -1) 📝 `spotify_player/src/state/ui/popup.rs` (+8 -1) 📝 `spotify_player/src/ui/popup.rs` (+1 -1) </details> ### 📄 Description ## Changes - renamed `Browse*` actions to `GoTo*` actions, e.g `BrowseAlbum` to `GoToAlbum` - added + `GoToArtistRadio`, `GoToAlbumRadio` actions for track + `GoToLibraryRadio` action for library + `GoToAlbumRadio`, `GoToArtistRadio` actions for album - implemented Spotify-like radio page by using librespot's Mercury APIs, which allows the list of recommended tracks to look similar to what is shown in the official Spotify app and to support radio pages of other Spotify items beside track and artist - added a TODO for fixing sorting not working in non-context pages --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:49:05 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#623
No description provided.