mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #58] [MERGED] Remove user:{user} part when parsing URIs #608
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#608
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/58
Author: @aome510
Created: 6/21/2022
Status: ✅ Merged
Merged: 6/21/2022
Merged by: @aome510
Base:
master← Head:debug-issue-57📝 Commits (1)
0404975removeuser:{user_id}part when parsing URIs📊 Changes
3 files changed (+34 additions, -14 deletions)
View changed files
📝
spotify_player/src/event/popup.rs(+4 -2)📝
spotify_player/src/state/player.rs(+15 -12)📝
spotify_player/src/utils.rs(+15 -0)📄 Description
Fixes #57.
Context
rspotifylibrary expects to receive an URI of formatspotify:{type}:{id}but URI returned from Spotify API can also have a format ofspotify:user:{user}:{type}:{id}, which cause the panic happened in the original issue. This PR fixes this issue by removing theuser:{user}part.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.