[PR #55] [MERGED] Action on item improvements P2 #605

New issue

Closed

opened 2026-03-02 23:49:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/55
Author: @aome510
Created: 6/13/2022
Status: ✅ Merged
Merged: 6/14/2022
Merged by: @aome510

Base: master ← Head: action-on-item-improv-p2

📝 Commits (9)

f391fc5 add LikedTrackPage command, keymap, and its handler
8ff5f43 implement AppData::get_tracks_by_id method
526c5eb add ui/utils.rs module
387fae7 adjust selected position for table/list window on rendering
dd1b623 add ClientRequest::DeleteTrackFromPlaylist and its handler
242ec11 add TrackAction::DeleteFromCurrentPlaylist and its handler
533d7ab not reset page state context ID when handling PreviousPage command
0d44a07 cleanup
8e8bb5d update README

📊 Changes

14 files changed (+264 additions, -123 deletions)

View changed files

📝 README.md (+4 -3)
📝 spotify_player/src/client/handlers.rs (+9 -4)
📝 spotify_player/src/client/mod.rs (+39 -7)
📝 spotify_player/src/command.rs (+5 -2)
📝 spotify_player/src/config/keymap.rs (+4 -0)
📝 spotify_player/src/event/mod.rs (+11 -7)
📝 spotify_player/src/event/page.rs (+1 -3)
📝 spotify_player/src/event/popup.rs (+15 -2)
📝 spotify_player/src/event/window.rs (+7 -4)
📝 spotify_player/src/state/data.rs (+10 -0)
📝 spotify_player/src/ui/mod.rs (+6 -39)
📝 spotify_player/src/ui/page.rs (+73 -49)
📝 spotify_player/src/ui/popup.rs (+5 -3)
➕ spotify_player/src/ui/utils.rs (+75 -0)

📄 Description

Changes

added TrackAction::DeleteFromCurrentPlaylist
added LikedTrackPage command and liked track page
renamed structs, functions for consistency ("save_to" -> "add_to", "remove_from" -> "delete_from")
implemented auto-indexing when rendering list/table (helpful when deleting the last item of a list/table)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/55 **Author:** [@aome510](https://github.com/aome510) **Created:** 6/13/2022 **Status:** ✅ Merged **Merged:** 6/14/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `action-on-item-improv-p2` --- ### 📝 Commits (9) - [`f391fc5`](https://github.com/aome510/spotify-player/commit/f391fc5216a0f3caef63a04b2642013263198543) add `LikedTrackPage` command, keymap, and its handler - [`8ff5f43`](https://github.com/aome510/spotify-player/commit/8ff5f43b9adaefcc236b875ce11d090cf66ccf08) implement `AppData::get_tracks_by_id` method - [`526c5eb`](https://github.com/aome510/spotify-player/commit/526c5eb19e03567883305544cc915b54c39caac5) add `ui/utils.rs` module - [`387fae7`](https://github.com/aome510/spotify-player/commit/387fae7ee1641e7357d6f189f48ad4f1260b01af) adjust `selected` position for table/list window on rendering - [`dd1b623`](https://github.com/aome510/spotify-player/commit/dd1b62368dbe81f3af3c5364e02e3224759b8bab) add `ClientRequest::DeleteTrackFromPlaylist` and its handler - [`242ec11`](https://github.com/aome510/spotify-player/commit/242ec119ba2ccef1e5094f5e394c7a6e4ca90411) add `TrackAction::DeleteFromCurrentPlaylist` and its handler - [`533d7ab`](https://github.com/aome510/spotify-player/commit/533d7ab7e26ab491d91f5fc8bbe22810a0f0d9b7) not reset page state context ID when handling `PreviousPage` command - [`0d44a07`](https://github.com/aome510/spotify-player/commit/0d44a07d6f44c290a3640fd27a1c6794c068cad7) cleanup - [`8e8bb5d`](https://github.com/aome510/spotify-player/commit/8e8bb5d3c1b97242cb786a2b27d5afe96d42a0e3) update README ### 📊 Changes **14 files changed** (+264 additions, -123 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+4 -3) 📝 `spotify_player/src/client/handlers.rs` (+9 -4) 📝 `spotify_player/src/client/mod.rs` (+39 -7) 📝 `spotify_player/src/command.rs` (+5 -2) 📝 `spotify_player/src/config/keymap.rs` (+4 -0) 📝 `spotify_player/src/event/mod.rs` (+11 -7) 📝 `spotify_player/src/event/page.rs` (+1 -3) 📝 `spotify_player/src/event/popup.rs` (+15 -2) 📝 `spotify_player/src/event/window.rs` (+7 -4) 📝 `spotify_player/src/state/data.rs` (+10 -0) 📝 `spotify_player/src/ui/mod.rs` (+6 -39) 📝 `spotify_player/src/ui/page.rs` (+73 -49) 📝 `spotify_player/src/ui/popup.rs` (+5 -3) ➕ `spotify_player/src/ui/utils.rs` (+75 -0) </details> ### 📄 Description ## Changes - added `TrackAction::DeleteFromCurrentPlaylist` - added `LikedTrackPage` command and liked track page - renamed structs, functions for consistency ("save_to" -> "add_to", "remove_from" -> "delete_from") - implemented auto-indexing when rendering list/table (helpful when deleting the last item of a list/table) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>