[PR #48] [MERGED] Add image feature #602

Closed
opened 2026-03-02 23:48:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/48
Author: @aome510
Created: 6/5/2022
Status: Merged
Merged: 6/10/2022
Merged by: @aome510

Base: masterHead: add-cover-feature


📝 Commits (10+)

  • b432905 add cover feature
  • ee3647f move get_track_album_image_url to utils
  • 7cb5634 retrieve track's cover image on playback update
  • 3676372 rename progress_bar_rect to playback_progress_bar_rect
  • ee351c5 render track's cover image (slow)
  • 247b147 add image render cache
  • d2a7ebc clean up
  • 73e2352 render the track cover image in a separate thread
  • fa9f479 re-render image when changing theme
  • 10a014c rewrite cover image render function using timer

📊 Changes

16 files changed (+587 additions, -36 deletions)

View changed files

📝 Cargo.lock (+370 -0)
📝 README.md (+22 -0)
📝 doc/config.md (+10 -9)
📝 examples/app.toml (+1 -0)
📝 spotify_player/Cargo.toml (+4 -1)
📝 spotify_player/src/client/mod.rs (+47 -2)
📝 spotify_player/src/config/mod.rs (+9 -0)
📝 spotify_player/src/event/mod.rs (+2 -2)
📝 spotify_player/src/main.rs (+11 -0)
📝 spotify_player/src/media_control.rs (+2 -9)
📝 spotify_player/src/state/data.rs (+4 -0)
📝 spotify_player/src/state/player.rs (+10 -3)
📝 spotify_player/src/state/ui/mod.rs (+10 -4)
📝 spotify_player/src/ui/mod.rs (+76 -5)
📝 spotify_player/src/ui/popup.rs (+1 -1)
📝 spotify_player/src/utils.rs (+8 -0)

📄 Description

Changes

  • implement rendering current track's cover image rendering support under image feature
    • added viuer and image as new dependencies
  • added cover_image_refresh_duration_in_ms config option

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/48 **Author:** [@aome510](https://github.com/aome510) **Created:** 6/5/2022 **Status:** ✅ Merged **Merged:** 6/10/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-cover-feature` --- ### 📝 Commits (10+) - [`b432905`](https://github.com/aome510/spotify-player/commit/b432905d0bebab8a288171816a55f03590b46f47) add `cover` feature - [`ee3647f`](https://github.com/aome510/spotify-player/commit/ee3647f4e5b710a5a58555726fdd1d484d8443e4) move `get_track_album_image_url` to `utils` - [`7cb5634`](https://github.com/aome510/spotify-player/commit/7cb56340174352bdc176a7b3046d2966f8ca13ca) retrieve track's cover image on playback update - [`3676372`](https://github.com/aome510/spotify-player/commit/36763723e43eb3eb9469578e8eb77e67f7790009) rename `progress_bar_rect` to `playback_progress_bar_rect` - [`ee351c5`](https://github.com/aome510/spotify-player/commit/ee351c5f4f8bab16970854ba225692b8767eaba9) render track's cover image (slow) - [`247b147`](https://github.com/aome510/spotify-player/commit/247b147b898a8a8c7395a3221153097ee94ac625) add image render cache - [`d2a7ebc`](https://github.com/aome510/spotify-player/commit/d2a7ebc436fddbd64e09686799fbac4bcae888c3) clean up - [`73e2352`](https://github.com/aome510/spotify-player/commit/73e2352456ac780dd31ebf7c56111c9af87b6357) render the track cover image in a separate thread - [`fa9f479`](https://github.com/aome510/spotify-player/commit/fa9f4794c6284fc7b2869f7cec208e54e2288e7b) re-render image when changing theme - [`10a014c`](https://github.com/aome510/spotify-player/commit/10a014c2d8e578515edcde2d5be045cd969c0108) rewrite cover image render function using timer ### 📊 Changes **16 files changed** (+587 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+370 -0) 📝 `README.md` (+22 -0) 📝 `doc/config.md` (+10 -9) 📝 `examples/app.toml` (+1 -0) 📝 `spotify_player/Cargo.toml` (+4 -1) 📝 `spotify_player/src/client/mod.rs` (+47 -2) 📝 `spotify_player/src/config/mod.rs` (+9 -0) 📝 `spotify_player/src/event/mod.rs` (+2 -2) 📝 `spotify_player/src/main.rs` (+11 -0) 📝 `spotify_player/src/media_control.rs` (+2 -9) 📝 `spotify_player/src/state/data.rs` (+4 -0) 📝 `spotify_player/src/state/player.rs` (+10 -3) 📝 `spotify_player/src/state/ui/mod.rs` (+10 -4) 📝 `spotify_player/src/ui/mod.rs` (+76 -5) 📝 `spotify_player/src/ui/popup.rs` (+1 -1) 📝 `spotify_player/src/utils.rs` (+8 -0) </details> ### 📄 Description ## Changes - implement rendering current track's cover image rendering support under `image` feature + added `viuer` and `image` as new dependencies - added `cover_image_refresh_duration_in_ms` config option --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:48:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#602
No description provided.