mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #27] 0.5.0 crashing badly #6
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#6
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @0323pin on GitHub (Nov 4, 2021).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/27
@aome510 Unfortunately 0.5.0 is crashing badly, had no issues on 0.4.0
Log file by e-mail
@aome510 commented on GitHub (Nov 4, 2021):
Wow that sucks 😢 . I just looked into the log file and it looks fine to me.
Can you elaborate in more details how did it crash? Does it happen frequently? I'm using
v0.5.0atm and it works normally for me.@aome510 commented on GitHub (Nov 4, 2021):
@0323pin I can partially guess the problem but it's pretty weird that it doesn't report the error in the log file.
I guess the issue is because you specify
client_id = '******'inapp.tomlwhich spotify libraries don't like. Hope this solves the problem.@0323pin commented on GitHub (Nov 5, 2021):
No, that was just me covering my actual client ID and username on the log file.
Thread panic. I'll try to write it down old fashion way because the window takes no input and I have to kill it through the window manager to close it.
Always, as soon as I try to do a search or play a song, I haven't been able to do anything.
@0323pin commented on GitHub (Nov 5, 2021):
@aome510 just one question before I go ahead and rebuild 0.5.0, what DE/WM do you use?
@aome510 commented on GitHub (Nov 5, 2021):
@0323pin I currently use macos daily. I still occasionally use Linux with i3 and Manjaro linux.
If it is thread panic, can you run
spotify_player 2> log.txtand then send me the log file so I can see the panic messages?@0323pin commented on GitHub (Nov 5, 2021):
Yes, I can do that but, I need to re-build it first.
That said, i wonder if we can get anything there.
I can launch the app and navigate the panes, the thread panic occurs when there is an input action.
I'll get back to you in 4 - 5 hours..
@0323pin commented on GitHub (Nov 5, 2021):
@aome510 Here's the requested output, also with RUST_BACKTRACE=1 and RUST_BACKTRACE=full.
I can actually play songs but, only those which are accessible without search. Hiting Enter or searching crashes the player.
At least, I can still listen to music but, I feel that I should not merge the update as is. 0.4.0 is for now the version available to the users. Don't want them to get the wrong impression, I've been using the player since 0.1.0 myself without these problems.
@aome510 commented on GitHub (Nov 5, 2021):
Thanks @0323pin. The log is helpful.
Can you confirm that the below is what you did to produce the panic:
spotify-playerwhich gets you to the Library page/to search the pageEnterJudging from the log, it seems that the error happens because
ChooseSelectedis called but there is no playlist to act on.@0323pin commented on GitHub (Nov 5, 2021):
@aome510 Yes, that's what I did to produce the thread panic.
I don't use playlists. Right now I'm stuck with Alice In Chains - Dirt, could be worst :)
I can start the song I was on by pressing Space but, if I hit Enter the same happens.
@aome510 commented on GitHub (Nov 5, 2021):
@0323pin pushed a fix in
github.com/aome510/spotify-player@7fa610b7f5. Please let me know if the error still persists@0323pin commented on GitHub (Nov 5, 2021):
@aome510 This solved the issue, thanks! 🥇
Should I merge 0.5.0 building the package from
7fa610bor, would you like to release 0.5.1?Thank you.
@aome510 commented on GitHub (Nov 5, 2021):
@0323pin great! I'll release
0.5.1with the fix soon 💪@0323pin commented on GitHub (Nov 5, 2021):
Awesome thanks 👍
@0323pin commented on GitHub (Nov 5, 2021):
@aome510 merged, https://mail-index.netbsd.org/pkgsrc-changes/2021/11/05/msg242861.html