[PR #36] [MERGED] Add a lyric page #594

New issue

Closed

opened 2026-03-02 23:48:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:48:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/36
Author: @aome510
Created: 5/14/2022
Status: ✅ Merged
Merged: 5/14/2022
Merged by: @aome510

Base: master ← Head: add-lyric-page

📝 Commits (10+)

3d66a3d add lyric page structs
054d835 add LyricPage command and default keybindings
5783d82 handle LyricPage command, add ClientRequest::GetLyric
d85f5f8 add lyric_finder::Client::from_http_client method
becb0fa add lyric_finder dep to spotify_player
b9e7d04 fix fold bug
bcd5889 render a simple lyric page
9d77bff improve client logging, add elapsed time
6769f32 update lyric_finder lib to handle not found case
3731215 colorize the lyric page text description

📊 Changes

21 files changed (+331 additions, -108 deletions)

View changed files

📝 Cargo.lock (+2 -1)
📝 Dockerfile (+1 -1)
📝 README.md (+41 -40)
📝 lyric_finder/Cargo.toml (+1 -1)
📝 lyric_finder/examples/lyric-finder.rs (+12 -4)
📝 lyric_finder/src/lib.rs (+41 -31)
📝 spotify_player/Cargo.toml (+3 -1)
📝 spotify_player/src/client/handlers.rs (+9 -4)
📝 spotify_player/src/client/mod.rs (+22 -2)
📝 spotify_player/src/command.rs (+7 -3)
📝 spotify_player/src/config/keymap.rs (+11 -0)
📝 spotify_player/src/event/mod.rs (+37 -2)
📝 spotify_player/src/event/page.rs (+37 -0)
📝 spotify_player/src/event/popup.rs (+12 -8)
📝 spotify_player/src/state/data.rs (+4 -0)
📝 spotify_player/src/state/model.rs (+8 -3)
📝 spotify_player/src/state/ui/page.rs (+13 -1)
📝 spotify_player/src/state/ui/popup.rs (+1 -1)
📝 spotify_player/src/ui/mod.rs (+4 -0)
📝 spotify_player/src/ui/page.rs (+58 -0)

...and 1 more files

📄 Description

Brief description of changes

integrated lyric_finder crate to implement the lyric page and related components (Command, ClientRequest, etc)
added lyric-finder feature (included by default)
updated lyric-finder crate to v0.1.2
- made the library's methods/structs more compatible and easier to integrate with spotify_player
added several small code improvements

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/36 **Author:** [@aome510](https://github.com/aome510) **Created:** 5/14/2022 **Status:** ✅ Merged **Merged:** 5/14/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-lyric-page` --- ### 📝 Commits (10+) - [`3d66a3d`](https://github.com/aome510/spotify-player/commit/3d66a3d0402d8f8168e3d4c2171dfaae690b31fd) add lyric page structs - [`054d835`](https://github.com/aome510/spotify-player/commit/054d835771423c9987b7d55299d8f80f2770cf95) add `LyricPage` command and default keybindings - [`5783d82`](https://github.com/aome510/spotify-player/commit/5783d8265ebed22da07636f81f60855ff186be38) handle `LyricPage` command, add `ClientRequest::GetLyric` - [`d85f5f8`](https://github.com/aome510/spotify-player/commit/d85f5f80a7c6f2b2cc3cb3bb0dec6d180b3aad7b) add `lyric_finder::Client::from_http_client` method - [`becb0fa`](https://github.com/aome510/spotify-player/commit/becb0faf55c57c88f0989d614f74195f5439ed69) add `lyric_finder` dep to `spotify_player` - [`b9e7d04`](https://github.com/aome510/spotify-player/commit/b9e7d04139504c78a1ffe564cc210567aabed68d) fix fold bug - [`bcd5889`](https://github.com/aome510/spotify-player/commit/bcd588914184ae9275c6c12f177466d9ab1871f7) render a simple lyric page - [`9d77bff`](https://github.com/aome510/spotify-player/commit/9d77bffe2e98b45b549c197a7662d7f4871094c8) improve client logging, add elapsed time - [`6769f32`](https://github.com/aome510/spotify-player/commit/6769f328134d4d9be42eb82e860d5c93fcd1c0fe) update `lyric_finder` lib to handle not found case - [`3731215`](https://github.com/aome510/spotify-player/commit/3731215fbba059515246fabfa6556a44c7267ed2) colorize the lyric page text description ### 📊 Changes **21 files changed** (+331 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+2 -1) 📝 `Dockerfile` (+1 -1) 📝 `README.md` (+41 -40) 📝 `lyric_finder/Cargo.toml` (+1 -1) 📝 `lyric_finder/examples/lyric-finder.rs` (+12 -4) 📝 `lyric_finder/src/lib.rs` (+41 -31) 📝 `spotify_player/Cargo.toml` (+3 -1) 📝 `spotify_player/src/client/handlers.rs` (+9 -4) 📝 `spotify_player/src/client/mod.rs` (+22 -2) 📝 `spotify_player/src/command.rs` (+7 -3) 📝 `spotify_player/src/config/keymap.rs` (+11 -0) 📝 `spotify_player/src/event/mod.rs` (+37 -2) 📝 `spotify_player/src/event/page.rs` (+37 -0) 📝 `spotify_player/src/event/popup.rs` (+12 -8) 📝 `spotify_player/src/state/data.rs` (+4 -0) 📝 `spotify_player/src/state/model.rs` (+8 -3) 📝 `spotify_player/src/state/ui/page.rs` (+13 -1) 📝 `spotify_player/src/state/ui/popup.rs` (+1 -1) 📝 `spotify_player/src/ui/mod.rs` (+4 -0) 📝 `spotify_player/src/ui/page.rs` (+58 -0) _...and 1 more files_ </details> ### 📄 Description ## Brief description of changes - integrated `lyric_finder` crate to implement the lyric page and related components (`Command`, `ClientRequest`, etc) - added `lyric-finder` feature (included by default) - updated `lyric-finder` crate to `v0.1.2` + made the library's methods/structs more compatible and easier to integrate with `spotify_player` - added several small code improvements --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>