[PR #37] [MERGED] Add various improvements #593

New issue

Closed

opened 2026-03-02 23:48:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:48:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/37
Author: @aome510
Created: 5/17/2022
Status: ✅ Merged
Merged: 5/17/2022
Merged by: @aome510

Base: master ← Head: improve-async-codes

📝 Commits (10+)

316b1e0 update doc, remove refresh_delay_in_ms_each_playback_update, n_refreshes_each_playback_update
6818799 rewrite playback update code using tokio::time
52a7a1f cleanup main.rs
439b007 write application's backtrace/panic info into a backtrace file
02eddfc remove tokio_stream
6e5629c minor tweak
91a7126 return error in UI functions
ff7b17a try to reduce the number of unwrap
f54df7c clean up
52523d1 fix clippy errors

📊 Changes

15 files changed (+271 additions, -143 deletions)

View changed files

📝 Cargo.lock (+61 -1)
📝 doc/config.md (+16 -13)
📝 examples/app.toml (+0 -2)
📝 spotify_player/Cargo.toml (+2 -2)
📝 spotify_player/src/client/handlers.rs (+1 -2)
📝 spotify_player/src/client/mod.rs (+36 -30)
📝 spotify_player/src/config/mod.rs (+0 -4)
📝 spotify_player/src/event/page.rs (+6 -6)
📝 spotify_player/src/event/popup.rs (+11 -4)
📝 spotify_player/src/event/window.rs (+2 -2)
📝 spotify_player/src/main.rs (+36 -18)
📝 spotify_player/src/spirc.rs (+6 -2)
📝 spotify_player/src/state/model.rs (+5 -10)
📝 spotify_player/src/ui/mod.rs (+28 -23)
📝 spotify_player/src/ui/page.rs (+61 -24)

📄 Description

Brief description of changes

added backtrace file to log the application's panic stacktrace
improved error handling
- reduce the panic codes (unwrap, unreachable, etc)
- add more context to propagated errors
code cleanup

Breaking changes

removed refresh_delay_in_ms_each_playback_update and n_refreshes_each_playback_update config options
- the playback update logic is now fixed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/37 **Author:** [@aome510](https://github.com/aome510) **Created:** 5/17/2022 **Status:** ✅ Merged **Merged:** 5/17/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `improve-async-codes` --- ### 📝 Commits (10+) - [`316b1e0`](https://github.com/aome510/spotify-player/commit/316b1e04c9266d0808d155df4be521e2cd1ef71d) update doc, remove `refresh_delay_in_ms_each_playback_update`, `n_refreshes_each_playback_update` - [`6818799`](https://github.com/aome510/spotify-player/commit/6818799981d97ec2c7ffb55dccb0afcdacfa9be7) rewrite playback update code using `tokio::time` - [`52a7a1f`](https://github.com/aome510/spotify-player/commit/52a7a1f105fbeb6c1d974a1c6f8cca8f59e6b3a7) cleanup `main.rs` - [`439b007`](https://github.com/aome510/spotify-player/commit/439b0078393dd9a42c11f4c5f35d54da33b5c4d6) write application's backtrace/panic info into a backtrace file - [`02eddfc`](https://github.com/aome510/spotify-player/commit/02eddfc28d2d09c4303a763703e2215e852c115c) remove `tokio_stream` - [`6e5629c`](https://github.com/aome510/spotify-player/commit/6e5629cde0ce309c83b45e13755a855f0a4188ec) minor tweak - [`91a7126`](https://github.com/aome510/spotify-player/commit/91a7126dcd4a7733772e9db571efc304c2aaa3b9) return error in UI functions - [`ff7b17a`](https://github.com/aome510/spotify-player/commit/ff7b17a5d794090468c2ceaf73e99ac0eec7ea3d) try to reduce the number of `unwrap` - [`f54df7c`](https://github.com/aome510/spotify-player/commit/f54df7c2ba189f942358de897c53b6cc83290cd7) clean up - [`52523d1`](https://github.com/aome510/spotify-player/commit/52523d1857cce2722758f98cb6753eff461a25a4) fix clippy errors ### 📊 Changes **15 files changed** (+271 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+61 -1) 📝 `doc/config.md` (+16 -13) 📝 `examples/app.toml` (+0 -2) 📝 `spotify_player/Cargo.toml` (+2 -2) 📝 `spotify_player/src/client/handlers.rs` (+1 -2) 📝 `spotify_player/src/client/mod.rs` (+36 -30) 📝 `spotify_player/src/config/mod.rs` (+0 -4) 📝 `spotify_player/src/event/page.rs` (+6 -6) 📝 `spotify_player/src/event/popup.rs` (+11 -4) 📝 `spotify_player/src/event/window.rs` (+2 -2) 📝 `spotify_player/src/main.rs` (+36 -18) 📝 `spotify_player/src/spirc.rs` (+6 -2) 📝 `spotify_player/src/state/model.rs` (+5 -10) 📝 `spotify_player/src/ui/mod.rs` (+28 -23) 📝 `spotify_player/src/ui/page.rs` (+61 -24) </details> ### 📄 Description ## Brief description of changes - added backtrace file to log the application's panic stacktrace - improved error handling + reduce the panic codes (`unwrap`, `unreachable`, etc) + add more context to propagated errors - code cleanup ## Breaking changes - removed `refresh_delay_in_ms_each_playback_update` and `n_refreshes_each_playback_update` config options + the playback update logic is now fixed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>