[PR #32] [MERGED] Add various UI improvements #589

Closed
opened 2026-03-02 23:48:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/32
Author: @aome510
Created: 3/5/2022
Status: Merged
Merged: 3/6/2022
Merged by: @aome510

Base: masterHead: various-ui-improvement


📝 Commits (10+)

  • daf636e specify item's name for actions popup
  • 2684316 change the width percentages of columns in the track table
  • b583884 add the seed track to the track recommendation list
  • d121507 add current_user_top_tracks and current_user_recently_played_tracks client functions
  • ef2cceb update command list
  • 80a9b35 add description and binding for new commands
  • 4ea1d5f Merge branch 'master' into various-ui-improvement
  • 0cb49ce handle commands moving to tracks page
  • d619cdc de-duplicate tracks when handling recently played request
  • d317f29 call requests when moving to library page

📊 Changes

8 files changed (+217 additions, -62 deletions)

View changed files

📝 README.md (+41 -39)
📝 spotify_player/src/client/mod.rs (+82 -2)
📝 spotify_player/src/command.rs (+6 -3)
📝 spotify_player/src/config/keymap.rs (+9 -1)
📝 spotify_player/src/event/mod.rs (+25 -2)
📝 spotify_player/src/state/model.rs (+33 -0)
📝 spotify_player/src/ui/page.rs (+5 -6)
📝 spotify_player/src/ui/popup.rs (+16 -9)

📄 Description

Brief description of changes

  • added item's name to the ActionList popup's title
  • added TopTrackPage and RecentlyPlayedTrackPage commands, along new client request GetUserTopTracks and GetUserRecentlyPlayedTracks and the corresponding handlers
  • added the seed track to the returned recommended tracks when handling recommendations request
  • tweaked the width percentage of columns in the track table

Breaking changes

  • renamed BrowsePlayingContext command to CurrentlyPlayingContextPage

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/32 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/5/2022 **Status:** ✅ Merged **Merged:** 3/6/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `various-ui-improvement` --- ### 📝 Commits (10+) - [`daf636e`](https://github.com/aome510/spotify-player/commit/daf636e841b905eff4dd6b8f9e65618a9ebdb586) specify item's name for actions popup - [`2684316`](https://github.com/aome510/spotify-player/commit/26843167be3d4830f4083b0460b489fd5639a2f0) change the width percentages of columns in the track table - [`b583884`](https://github.com/aome510/spotify-player/commit/b583884d05dd54fe762a8bb0d32daea394c85b4f) add the seed track to the track recommendation list - [`d121507`](https://github.com/aome510/spotify-player/commit/d1215077c913f8b8412cfd2cbcd479ec6268cae5) add `current_user_top_tracks` and `current_user_recently_played_tracks` client functions - [`ef2cceb`](https://github.com/aome510/spotify-player/commit/ef2cceb5f3a76cabd66d7f1ccc5df135d38b2443) update command list - [`80a9b35`](https://github.com/aome510/spotify-player/commit/80a9b354ddc19d7c3b1541c4fdb1487b666ea157) add description and binding for new commands - [`4ea1d5f`](https://github.com/aome510/spotify-player/commit/4ea1d5f5b2979be95fcd030ca2f4bb3c3e05b9cd) Merge branch 'master' into various-ui-improvement - [`0cb49ce`](https://github.com/aome510/spotify-player/commit/0cb49ce12f67a1bbac94b17fc3fc416e8bf145c3) handle commands moving to tracks page - [`d619cdc`](https://github.com/aome510/spotify-player/commit/d619cdc59cf5124cfa999a51a8e0c0d6b6411b5c) de-duplicate tracks when handling recently played request - [`d317f29`](https://github.com/aome510/spotify-player/commit/d317f29eb186a46a1da075c24a5ebe2ace543db2) call requests when moving to library page ### 📊 Changes **8 files changed** (+217 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+41 -39) 📝 `spotify_player/src/client/mod.rs` (+82 -2) 📝 `spotify_player/src/command.rs` (+6 -3) 📝 `spotify_player/src/config/keymap.rs` (+9 -1) 📝 `spotify_player/src/event/mod.rs` (+25 -2) 📝 `spotify_player/src/state/model.rs` (+33 -0) 📝 `spotify_player/src/ui/page.rs` (+5 -6) 📝 `spotify_player/src/ui/popup.rs` (+16 -9) </details> ### 📄 Description ## Brief description of changes - added item's name to the `ActionList` popup's title - added `TopTrackPage` and `RecentlyPlayedTrackPage` commands, along new client request `GetUserTopTracks` and `GetUserRecentlyPlayedTracks` and the corresponding handlers - added the seed track to the returned recommended tracks when handling `recommendations` request - tweaked the width percentage of columns in the track table ### Breaking changes - renamed `BrowsePlayingContext` command to `CurrentlyPlayingContextPage` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:48:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#589
No description provided.