[PR #24] [MERGED] Add a library page #584

New issue

Closed

opened 2026-03-02 23:48:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:48:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/24
Author: @aome510
Created: 10/31/2021
Status: ✅ Merged
Merged: 10/31/2021
Merged by: @aome510

Base: master ← Head: add-library-page

📝 Commits (10+)

9b5bd4e add PageState::Library and WindowState::Library enum variant
df51d69 add ui/window.rs module
1dfa3ea implement render function for library page
e32c731 change the layout of the library window
1c76958 implement key sequence/command handler for library window
78643e2 change some commands' name and description
35e7e1a keep handling command for library window when having a search popup
eca5ffb rename some theme components
fbb5afd tweak the borders of the library page
674e42e update README to not include all example sections

📊 Changes

17 files changed (+795 additions, -579 deletions)

View changed files

📝 README.md (+37 -40)
📝 doc/config.md (+6 -6)
📝 examples/theme.toml (+3 -3)
📝 scripts/theme_parse (+3 -3)
📝 spotify_player/src/command.rs (+10 -6)
📝 spotify_player/src/config/keymap.rs (+5 -1)
📝 spotify_player/src/config/theme.rs (+9 -9)
📝 spotify_player/src/event/mod.rs (+7 -0)
📝 spotify_player/src/event/popup.rs (+5 -1)
📝 spotify_player/src/event/window.rs (+64 -2)
📝 spotify_player/src/state/model.rs (+6 -0)
📝 spotify_player/src/state/ui.rs (+45 -1)
➖ spotify_player/src/ui/context.rs (+0 -176)
📝 spotify_player/src/ui/help.rs (+1 -1)
📝 spotify_player/src/ui/mod.rs (+33 -158)
➖ spotify_player/src/ui/search.rs (+0 -172)
➕ spotify_player/src/ui/window.rs (+561 -0)

📄 Description

Brief description of changes

add a library page and use it the starting page
add command::LibraryPage to go to the library page
rename some commands' name and description
rename some UI theme components
move all render functions for windows in the UI module to ui/window.rs

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/24 **Author:** [@aome510](https://github.com/aome510) **Created:** 10/31/2021 **Status:** ✅ Merged **Merged:** 10/31/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-library-page` --- ### 📝 Commits (10+) - [`9b5bd4e`](https://github.com/aome510/spotify-player/commit/9b5bd4ea9b63efa8dd84f43b755350a07636e51b) add `PageState::Library` and `WindowState::Library` enum variant - [`df51d69`](https://github.com/aome510/spotify-player/commit/df51d69002f0dbe5a9e6fd3a3f3b191da39e5b17) add `ui/window.rs` module - [`1dfa3ea`](https://github.com/aome510/spotify-player/commit/1dfa3eacad5a90bc684e01929005e40b3bbc79bf) implement render function for library page - [`e32c731`](https://github.com/aome510/spotify-player/commit/e32c731dee6a4141fcace4ca80736754dde7ce40) change the layout of the library window - [`1c76958`](https://github.com/aome510/spotify-player/commit/1c76958123b882f3b707d90fda471a85bbbcef8c) implement key sequence/command handler for library window - [`78643e2`](https://github.com/aome510/spotify-player/commit/78643e2ab688f1da1389ab564717c7adeb0ecf9a) change some commands' name and description - [`35e7e1a`](https://github.com/aome510/spotify-player/commit/35e7e1a6b6ddf725ced31cdcdb507a5e0dd5044b) keep handling command for library window when having a search popup - [`eca5ffb`](https://github.com/aome510/spotify-player/commit/eca5ffb31b88f32e16f391a889a7da0ef59c4715) rename some theme components - [`fbb5afd`](https://github.com/aome510/spotify-player/commit/fbb5afd9810b73f95db1dacff6b01979adc8d976) tweak the borders of the library page - [`674e42e`](https://github.com/aome510/spotify-player/commit/674e42ead96b7ebb89109070ba13426fc2f6dc26) update `README` to not include all example sections ### 📊 Changes **17 files changed** (+795 additions, -579 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+37 -40) 📝 `doc/config.md` (+6 -6) 📝 `examples/theme.toml` (+3 -3) 📝 `scripts/theme_parse` (+3 -3) 📝 `spotify_player/src/command.rs` (+10 -6) 📝 `spotify_player/src/config/keymap.rs` (+5 -1) 📝 `spotify_player/src/config/theme.rs` (+9 -9) 📝 `spotify_player/src/event/mod.rs` (+7 -0) 📝 `spotify_player/src/event/popup.rs` (+5 -1) 📝 `spotify_player/src/event/window.rs` (+64 -2) 📝 `spotify_player/src/state/model.rs` (+6 -0) 📝 `spotify_player/src/state/ui.rs` (+45 -1) ➖ `spotify_player/src/ui/context.rs` (+0 -176) 📝 `spotify_player/src/ui/help.rs` (+1 -1) 📝 `spotify_player/src/ui/mod.rs` (+33 -158) ➖ `spotify_player/src/ui/search.rs` (+0 -172) ➕ `spotify_player/src/ui/window.rs` (+561 -0) </details> ### 📄 Description ## Brief description of changes - add a library page and use it the starting page - add `command::LibraryPage` to go to the library page - rename some commands' name and description - rename some UI theme components - move all render functions for windows in the UI module to `ui/window.rs` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>