[PR #11] [MERGED] [#10] Add scroll shortcuts for help popup #573

New issue

Closed

opened 2026-03-02 23:48:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:48:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/11
Author: @aome510
Created: 10/8/2021
Status: ✅ Merged
Merged: 10/8/2021
Merged by: @aome510

Base: master ← Head: add-scroll-shortcuts-for-help-popup

📝 Commits (3)

a3a9878 add offset to the CommandHelp popup state
8fe51e6 rename SelectNext to SelectNextOrScrollDown, SelectPrevious to SelectPreviousOrScrollUp
a9ac995 use scroll shortcuts to modify the offset of the command help popup

📊 Changes

7 files changed (+66 additions, -36 deletions)

View changed files

📝 README.md (+2 -2)
📝 spotify_player/src/command.rs (+6 -4)
📝 spotify_player/src/config/keymap.rs (+6 -6)
📝 spotify_player/src/event.rs (+36 -19)
📝 spotify_player/src/state/ui.rs (+3 -3)
📝 spotify_player/src/ui/help.rs (+12 -1)
📝 spotify_player/src/ui/popup.rs (+1 -1)

📄 Description

Part 1 of #10

Brief description of changes

rename SelectNext to SelectNextOrScrollDown, SelectPrevious to SelectPreviousOrScrollUp
add offset to command help popup state
add command handlers for scroll shortcuts in help popup

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/11 **Author:** [@aome510](https://github.com/aome510) **Created:** 10/8/2021 **Status:** ✅ Merged **Merged:** 10/8/2021 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-scroll-shortcuts-for-help-popup` --- ### 📝 Commits (3) - [`a3a9878`](https://github.com/aome510/spotify-player/commit/a3a98782b8b15f1fccfb9469f6693b36267a746b) add `offset` to the `CommandHelp` popup state - [`8fe51e6`](https://github.com/aome510/spotify-player/commit/8fe51e6a208a165ca3920ee8675898dd9b6312ac) rename `SelectNext` to `SelectNextOrScrollDown`, `SelectPrevious` to `SelectPreviousOrScrollUp` - [`a9ac995`](https://github.com/aome510/spotify-player/commit/a9ac995099f4cd6fdf45809fa9fd38e59812e4b3) use scroll shortcuts to modify the offset of the command help popup ### 📊 Changes **7 files changed** (+66 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -2) 📝 `spotify_player/src/command.rs` (+6 -4) 📝 `spotify_player/src/config/keymap.rs` (+6 -6) 📝 `spotify_player/src/event.rs` (+36 -19) 📝 `spotify_player/src/state/ui.rs` (+3 -3) 📝 `spotify_player/src/ui/help.rs` (+12 -1) 📝 `spotify_player/src/ui/popup.rs` (+1 -1) </details> ### 📄 Description Part 1 of #10 **Brief description of changes** - rename `SelectNext` to `SelectNextOrScrollDown`, `SelectPrevious` to `SelectPreviousOrScrollUp` - add `offset` to command help popup state - add command handlers for scroll shortcuts in help popup --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>