starred/spotify-player

Fork 0

mirror of https://github.com/aome510/spotify-player.git synced 2026-04-26 09:25:49 +03:00

[GH-ISSUE #753] Action menu shortcut numbers not working anymore #446

New issue

Closed

opened 2026-03-02 23:47:34 +03:00 by kerem · 4 comments

kerem commented

2026-03-02 23:47:34 +03:00

Owner

Originally created by @bartlibert on GitHub (Jun 23, 2025).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/753

Describe the bug
When I open the action menu on a track (a or g a shorcut by default), the "number" shortcuts don't work anymore. This started with 0.20.6, so I guess the "vim like motions" change (which is great by the way!), caused this.

To Reproduce

Make sure there is an active track in spotify_player
Press a to open the actions for the current track
Press 2 for GoToRadio
Observe nothing happens

Expected behaviour
After pressing 2, the radio for the current track should be started

Screenshots

Environment

OS: Arch Linux
Application version: 0.20.6
Application features: --no-default-features --features notify,pulseaudio-backend,media-control,daemon,image,sixel,fzf

Originally created by @bartlibert on GitHub (Jun 23, 2025). Original GitHub issue: https://github.com/aome510/spotify-player/issues/753 **Describe the bug** When I open the action menu on a track (`a` or `g a` shorcut by default), the "number" shortcuts don't work anymore. This started with 0.20.6, so I guess the "vim like motions" change (which is great by the way!), caused this. **To Reproduce** - Make sure there is an active track in spotify_player - Press `a` to open the actions for the current track - Press `2` for `GoToRadio` - Observe nothing happens **Expected behaviour** After pressing `2`, the radio for the current track should be started **Screenshots** ![Image](https://github.com/user-attachments/assets/3cf5778a-9f7f-49f6-b438-7f490da8a728) **Environment** - OS: Arch Linux - Application version: 0.20.6 - Application features: --no-default-features --features notify,pulseaudio-backend,media-control,daemon,image,sixel,fzf

kerem

2026-03-02 23:47:34 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-02 23:47:35 +03:00

Author

Owner

@aome510 commented on GitHub (Jun 23, 2025):

Thanks for reporting! @markgandolfo is this something you can help take a look?

@aome510 commented on GitHub (Jun 23, 2025): Thanks for reporting! @markgandolfo is this something you can help take a look?

kerem commented

2026-03-02 23:47:35 +03:00

Author

Owner

@markgandolfo commented on GitHub (Jun 24, 2025):

I'll have a look tonight

@markgandolfo commented on GitHub (Jun 24, 2025): I'll have a look tonight

kerem commented

2026-03-02 23:47:35 +03:00

Author

Owner

@markgandolfo commented on GitHub (Jun 24, 2025):

I think we can just disable it for all ui.popup do you see any issue with that?
Also, any thoughts on adding some tests to ./tests/? I'm happy to write a unit test for this.

diff --git a/spotify_player/src/event/mod.rs b/spotify_player/src/event/mod.rs
index 117cc89..41d361f 100644
--- a/spotify_player/src/event/mod.rs
+++ b/spotify_player/src/event/mod.rs
@@ -101,22 +101,25 @@ fn handle_key_event(
     let mut ui = state.ui.lock();

     // Check if the key is a digit and handle count prefix
-    if let Key::None(KeyCode::Char(c)) = key {
-        if c.is_ascii_digit() {
-            let digit = c.to_digit(10).unwrap() as usize;
-            // If we have an existing count prefix, append the digit
-            // Otherwise, start a new count (but ignore leading zeros)
-            ui.count_prefix = match ui.count_prefix {
-                Some(count) => Some(count * 10 + digit),
-                None => {
-                    if digit > 0 {
-                        Some(digit)
-                    } else {
-                        None
+    // Only handle vim motions when not in a popup to avoid interfering with action selection
+    if ui.popup.is_none() {
+        if let Key::None(KeyCode::Char(c)) = key {
+            if c.is_ascii_digit() {
+                let digit = c.to_digit(10).unwrap() as usize;
+                // If we have an existing count prefix, append the digit
+                // Otherwise, start a new count (but ignore leading zeros)
+                ui.count_prefix = match ui.count_prefix {
+                    Some(count) => Some(count * 10 + digit),
+                    None => {
+                        if digit > 0 {
+                            Some(digit)
+                        } else {
+                            None
+                        }
                     }
-                }
-            };
-            return Ok(());
+                };
+                return Ok(());
+            }
         }
     }

@markgandolfo commented on GitHub (Jun 24, 2025): I think we can just disable it for all `ui.popup` do you see any issue with that? Also, any thoughts on adding some tests to `./tests/`? I'm happy to write a unit test for this. ```diff diff --git a/spotify_player/src/event/mod.rs b/spotify_player/src/event/mod.rs index 117cc89..41d361f 100644 --- a/spotify_player/src/event/mod.rs +++ b/spotify_player/src/event/mod.rs @@ -101,22 +101,25 @@ fn handle_key_event( let mut ui = state.ui.lock(); // Check if the key is a digit and handle count prefix - if let Key::None(KeyCode::Char(c)) = key { - if c.is_ascii_digit() { - let digit = c.to_digit(10).unwrap() as usize; - // If we have an existing count prefix, append the digit - // Otherwise, start a new count (but ignore leading zeros) - ui.count_prefix = match ui.count_prefix { - Some(count) => Some(count * 10 + digit), - None => { - if digit > 0 { - Some(digit) - } else { - None + // Only handle vim motions when not in a popup to avoid interfering with action selection + if ui.popup.is_none() { + if let Key::None(KeyCode::Char(c)) = key { + if c.is_ascii_digit() { + let digit = c.to_digit(10).unwrap() as usize; + // If we have an existing count prefix, append the digit + // Otherwise, start a new count (but ignore leading zeros) + ui.count_prefix = match ui.count_prefix { + Some(count) => Some(count * 10 + digit), + None => { + if digit > 0 { + Some(digit) + } else { + None + } } - } - }; - return Ok(()); + }; + return Ok(()); + } } } ```

kerem commented

2026-03-02 23:47:35 +03:00

Author

Owner

@markgandolfo commented on GitHub (Jun 24, 2025):

pull request - https://github.com/aome510/spotify-player/pull/754

@markgandolfo commented on GitHub (Jun 24, 2025): pull request - https://github.com/aome510/spotify-player/pull/754

kerem referenced this issue

2026-03-03 00:01:31 +03:00

[PR #931] [MERGED] feat: add mouse scroll to incease/decrease volume #932

kerem referenced this issue

2026-03-14 13:51:06 +03:00