mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #641] Better control in fzf searching #370
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#370
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @khaosdoctor on GitHub (Dec 17, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/641
Is your feature already implemented in the latest
master? NoIs your feature request related to a problem? Please describe.
Being able to use fzf with
/to find tracks in the liked songs (gy), for example, is an awesome addition. The problem is that once searched, I can't do anything other than play the track. If I want to add the searched track to the queue, this is not possible because every command will be typed in the search field. I've triedC-space, change focus, but nothing works. The only key that works isenter, if I pressC-spaceI'm thrown back at the top of my liked songs list.Describe the solution you'd like
It would be nice if the fzf search for every page worked like the search page, e.g: press
/a new field pops below the current playing song progress bar, you can type in and the list is being filtered as you type. But, as you pressFocusNextPaneyou drop to the results list where you can apply the same commands as you would be able to in the liked songs list or the search results listDescribe alternatives you've considered
What I'm doing today is that I use the search page to search for the song I want, even though I know the song is already saved in my library and then I use
Zto add to the queue.Additional context
Version: 0.20.4
MacOS Sequoia 15.1.1
Installed through Cargo with all the features
@aome510 commented on GitHub (Dec 17, 2024):
Yes, but it should show a popup for you to initiate an action on the selected track.
No, not every command. Commands with key bindings
control + {char}oralt + {char}still work in the search. FYI,AddSelectedItemToQueuedoes have aC-z(control+z) binding. You can also define your own keybindings for a command for it to work with search.Search is intended to be interactive. The solution you'd like to see defeats that purpose
@khaosdoctor commented on GitHub (Dec 18, 2024):
I see thanks for the clarification, in any case there’s the C-space bug, if I press it, the interactive search goes away and I’m thrown back at the top of the list.
Regarding the fzf search, would it be possible to add the binding to move to the next pane and unfocus the search box? This would solve all the issues
@wiraki commented on GitHub (Aug 30, 2025):
Just started using spotify-player, it's awesome! Thank you for making it.
It's amazing to have fzf support, but in my first hour of using it I did struggle with the same problem described in this issue.
That's for the top result of the fzf-search, which will be considered as "selected". Which means that I have to carefully adjust my query to make sure the track I am looking for and I want to interact with be the top result. I would argue this beats the purpose of fuzzy searching.
In my mind, after popping up the search, typing a few characters (might even make some typos) and filtering down the items, it would then make sense to be able to "browse" through the search results, before taking any action.
@khaosdoctor said:
Indeed, this would be a solution and initially I was expecting this to be possible from reading the documentation:
But that is not true when fuzzy search is enabled apparently? Is that right? If so, a clarification would be good in the documentation. (I can make the contribution when I completely understand how the fuzzy search works).
As a workaround, I found that after fuzzy searching I can use the arrow keys to navigate the search results.
@juliamertz commented on GitHub (Oct 12, 2025):
I ran into the same problem, so I've added an option for modal input in
github.com/juliamertz/spotify-player@afe2bc61ccIf the option is enabled, you're put into insert mode when searching. Then if you press escape (or enter to submit the query), you're put into normal mode so you can browse the results pane and use all the keybinds.
I wrote this a while ago, but if there's interest, I can finish it up and open a PR.