mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #97] terminal ansi colors #34
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#34
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sewnie on GitHub (Jan 5, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/97
Originally assigned to: @aome510 on GitHub.
by default, it seems that spotify_player uses it's own colors. for a CLI/TUI application i don't think this is a very good idea. spotify_player should use the terminal's colors - aka ANSI colors.
@aome510 commented on GitHub (Jan 6, 2023):
By the app's own colors, I'll assume that you're referring to the required colors mentioned in theme's palette documentation.
I believe defining the app's own colors this way allows to define more custom themes. I'm not too sure about the approaches other CLI/TUI applications take. Any resources would be helpful.
@sewnie commented on GitHub (Jan 7, 2023):
thats not exactly what i meant; for example a program can use the current terminals colors, for example heres a simple printf that will use ANSI to ask the terminal to print the text in red, and then reset the colors:
i believe many programs do this; such as spotify-tui.
@aome510 commented on GitHub (Jan 7, 2023):
Thanks for the clarification. Does that mean adding a new theme, e.g called "default", that uses the terminal's default colors should work?
@sewnie commented on GitHub (Jan 7, 2023):
i guess?
@sewnie commented on GitHub (Jan 9, 2023):
IMO there shouldnt be themes built in into spotify-player. the default and the only default should be ANSI colors and supports themes via configuration; with templates/themes from the project repo.
@euglevi commented on GitHub (Jan 16, 2023):
I think this feature is a must in terms of theming. I change my terminal theme quite often, it looks like a downsize having to change the spotify-player theme too.
@aome510 commented on GitHub (Jan 17, 2023):
This issue should be resolved by #107, which removed builtin themes and used a single theme based on terminal's ANSI colors.
The default theme change can be considered as a breaking change, so there should a while till this change is released with a new major version.
In the meantime, @wael444, @euglevi, can you guys test the latest build of the
masterbranch to see if it works as expected?Note that it may require to update the theme's configurations, so please refer to themes documentation for references. Feel free to reopen this issue if encounter any related issues.
@sewnie commented on GitHub (Jan 17, 2023):
Yes. though the color of the green accent is a little too light, should be the default green color
2instead of10@aome510 commented on GitHub (Jan 17, 2023):
Which component are you referring? I think it depends on the terminal's theme. The theme looks fine for me:
If things don't work, you can always create a new theme based on the "default" theme and update the corresponding component styles.
@sewnie commented on GitHub (Jan 17, 2023):
@euglevi commented on GitHub (Jan 17, 2023):
It seems to me it works well. Thank you! I have tried with a few themes. I will try more in the next days, but I have no reason to think I will experience any issues.
lyric_finderlib crate #591lyric_finderlib crate #1528