mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #535] [Feature]: Ability to further customize layout #308
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#308
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NickTheWilder on GitHub (Aug 7, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/535
Describe the solution you'd like
I personally never use Albums & Artists in Spotify, only playlist to sort songs. It would be nice to be able to
Describe alternatives you've considered
Adjusting the layout of playlists/albums in the config to potentially hide the columns
ℹ️ FWIW the layout settings don't work for me, Win11 - PowerShell v7.4.4 - scoop v0.19.1
Current settings:
Additional context
I'd start working on this if I had experience with Rust and open a PR but no experience here. Really enjoy what's going on so far.
Example to further describe what I'm talking about
Current view:

Proposed view: (or smth similar)

@sewnie commented on GitHub (Aug 7, 2024):
Would love to see this, it bridges the gap between the official spotify client and the better TUI counterpart.
@DOD-101 commented on GitHub (Aug 13, 2024):
I'm looking into implementing this.
That's strange. Are you on the latest git?
@arvvnd commented on GitHub (Aug 14, 2024):
The playback settings don't seem to work for me either, but in my case I tried to change the
playback_window_position = Bottom.I run kitty on arch and I'm using the AUR package
spotify-player-full-pipe.inside my app.toml :
I launch spotify-player in kitty using the command
spotify_playerand connect to my own client ID. I am able to edit other settings on the app.toml file like theme, icons, etc., and observe these changes. However, when I edit the [layout] settings, nothing changes. I even changedplayback_window_heightfrom its default value of 6 to 12 to see if the [layout] settings would take effect, but the playback window size remained the same. After making changes to app.toml, I save the file, restart kitty, and open the player with thespotify_playercommand to check for changes.I can open a separate issue if needed. I'm adding a comment here since the OP of this issue also mentions that their layout settings are not working. Also, I am not completely sure if it's a fault on my end or an actual bug. I can provide my entire app.toml file if anyone wants to review it!
@DOD-101 commented on GitHub (Aug 14, 2024):
This Issue primarily focuses on implementing the requested feature. So there should be a separate issue if there are any bugs with the existing code.
That being said, it sounds like this isn't an actual bug in the code, at least in your case @arvvnd.
The problem is that
spotify-player-full-pipeis built off of the latest stable release, and the changes to the layout config haven't yet been released. They are only available if you build from source on the master branch.@arvvnd commented on GitHub (Aug 14, 2024):
Thanks for the clarification @DOD-101 I guess it was indeed an error on my part. I prefer to install packages wherever possible and the playback window positioning is only a QoL upgrade(for me). I'm okay with waiting for the layout config update to
spotify-player-full-pipe.@aome510 commented on GitHub (Aug 17, 2024):
The library page in the official Spotify shows a side bar listing all playlists, albums, etc and a main window to display the selected item.
My idea to implement this feature for
spotify_playeris to add a "preview" window to the library page which renders a context window for the selected item. There are a few things to be considered:ChooseSelectedto go into the corresponding pagerender_context_pageto render the preview window?github.com/aome510/spotify-player@04f17631ce/spotify_player/src/ui/page.rs (L188)This seems to be a complicated yet interesting feature to add into
spotify_player. That said, I'll not work on this cause I don't really need one, but anyone feels free to pick it up. I'll try to assist as much as I can.v0.16.0#712v0.16.0#1651