mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 01:15:55 +03:00
[GH-ISSUE #531] Allow spotify-player to launch without an internet connection #306
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#306
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DOD-101 on GitHub (Aug 1, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/531
Is your feature already implemented in the latest
master?No.
Is your feature request related to a problem? Please describe.
When you try to launch spotify-player without an internet connection, it won't even show the UI simply printing:
If spotify-player is already running (at least as a daemon) it will crash when it doesn't have an internet connection anymore.
Describe the solution you'd like
Ideally, spotify-player would launch, showing you the UI and then tell you there that it requires an internet connection to play music. This would not only make developing easier, without an internet connection, but would also make it clearer to people that the app works, but requires internet to play music.
The daemon on the other hand would continue running, without playing music, when an internet connection is lost and launch, but not play any music, without an internet connection.
Describe alternatives you've considered
The daemon crashing isn't the most important thing, as one could set it up to restart, when connected to the internet again.
Additional context
Add any other context or screenshots about the feature request here.
@sewnie commented on GitHub (Aug 1, 2024):
This might be a duplicate of https://github.com/aome510/spotify-player/issues/333
@DOD-101 commented on GitHub (Aug 1, 2024):
Not quite.
This issue isn't asking for the ability to play locally stored music, but just to be able to have the UI / daemon run without an internet connection.
Although playing local music would be more useful if you could do it offline.
@aome510 commented on GitHub (Aug 1, 2024):
So basically https://github.com/aome510/spotify-player/issues/62. I tried to think about this feature before. It was difficult because you need Spotify API to access most of the data used by the app.
Ideally, the offline mode will only operate on cached/downloaded data.
edit: nvm I misunderstood the thread. The app doesn't crash upon no internet connection. The error you show in the issue is when you launch it. If the app is running and no internet available, it keeps running. Then it will automatically recover upon network re-connection or when you trigger a restart with
RestartIntegratedClientcommand.@DOD-101 commented on GitHub (Aug 2, 2024):
Yes, only the daemon seems to crash.
Yes, and I would like this error to show up in the UI (in the playback section), rather than the app exiting.
The client does do this, but not the daemon.
I've updated the wording in the original message to hopefully make this clearer.
Potentially, this could be split into two different Issues:
@sewnie commented on GitHub (Aug 2, 2024):
Why even allow the UI to display such a message when that's all it will do, forever?
How it is now is better, because without internet nothing can be done anyway.
@DOD-101 commented on GitHub (Aug 2, 2024):
Because it would allow people working on the project to compile and run the application without an Internet connection.
Or for example, if you are working on your config, you'd be able to view your changes without an internet connection.
In addition to this, if you want to the ability to play local songs through spotify-player in the future (#333) this would be a very useful first step in supporting that.
@sewnie commented on GitHub (Aug 2, 2024):
I agree, but keep in mind compiling the application requires fetching a significant amount of dependencies, if they're not already cached you can't build.