mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #521] Add better lyrics support with synced lyrics using librespot. #295
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#295
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @abdul2801 on GitHub (Jul 29, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/521
Is your feature already implemented in the latest
master?Partially implemented.
Is your feature request related to a problem? Please describe.
Currently the lyrics support uses an external api which is unreliable and dosent support synced lyrics.
Describe the solution you'd like
The github master and dev version of librespot supports getting lyrics from spotify with the synced timestamp.Will need to update librespot libraries to newer version , fix breaking changes and implement the lyrics.
Additional context
I am interested in working on this if it aligns with the project's needs.
@aome510 commented on GitHub (Jul 29, 2024):
I would prefer waiting
librespotto release a new version than integrating the latest, unstable dev version.Related: https://github.com/aome510/spotify-player/issues/513
@JingYenLoh commented on GitHub (Dec 5, 2024):
Now that spotify-player is using librespot 0.6 which seems to have lyrics support, what changes are necessary to support this? I skimmed through the documentation and it seems like one can retrieve lyrics using a SpotifyId, but I'm not sure how to retrieve the ID. Can it be extracted via the currently playing item?