[GH-ISSUE #479] Incorrect like status in ShowActions #271

Closed
opened 2026-03-02 23:46:07 +03:00 by kerem · 2 comments
Owner

Originally created by @71zenith on GitHub (Jun 28, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/479

Describe the bug
A clear and concise description of what the bug is.
If i open a ShowActionOnSelectedItem, it will show "AddLiked" when its already liked and "DeleteFromLiked" when its not liked. Clicking on them will not do anything, at least not that i can detect.

To Reproduce
Open Spotify-player. use Showactionsonselecteditem or ShowActionsOnCurrentTrack

Expected behaviour
It should show vice versa and actually like/dislike the selected item

Screenshots
image

  • OS:
  • Application version: bcba2e6
  • Application features: streaming,daemon,rodio,lyrics.image,notify,sixel,fzf
    Additional context
Originally created by @71zenith on GitHub (Jun 28, 2024). Original GitHub issue: https://github.com/aome510/spotify-player/issues/479 **Describe the bug** A clear and concise description of what the bug is. If i open a ShowActionOnSelectedItem, it will show "AddLiked" when its already liked and "DeleteFromLiked" when its not liked. Clicking on them will not do anything, at least not that i can detect. **To Reproduce** Open Spotify-player. use Showactionsonselecteditem or ShowActionsOnCurrentTrack **Expected behaviour** It should show vice versa and actually like/dislike the selected item **Screenshots** ![image](https://github.com/aome510/spotify-player/assets/92977828/cd6137dc-7fa6-48b9-8201-8fa8d8e7a375) - OS: - Application version: [bcba2e6](https://github.com/aome510/spotify-player/tree/bcba2e6cfa4ac989e003345b40c5809498805837) - Application features: streaming,daemon,rodio,lyrics.image,notify,sixel,fzf **Additional context**
kerem 2026-03-02 23:46:07 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@aome510 commented on GitHub (Jun 28, 2024):

Right, it's a bug introduced in github.com/aome510/spotify-player@bcba2e6cfa (diff-aaa651a1b).

Thanks for reporting.

<!-- gh-comment-id:2197408915 --> @aome510 commented on GitHub (Jun 28, 2024): Right, it's a bug introduced in https://github.com/aome510/spotify-player/commit/bcba2e6cfa4ac989e003345b40c5809498805837#diff-aaa651a1b85c3377b86aecc56c92a0ceed8bc99d8c65025356684c2eea3b55edL137-L141. Thanks for reporting.
Author
Owner

@deauthe commented on GitHub (Jun 30, 2024):

created a PR for this issue

<!-- gh-comment-id:2198511854 --> @deauthe commented on GitHub (Jun 30, 2024): created a PR for this issue
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#271
No description provided.