[PR #911] [MERGED] fix 0 key not working in popups #1856

Closed
opened 2026-03-14 15:36:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/911
Author: @xdBronch
Created: 1/11/2026
Status: Merged
Merged: 1/13/2026
Merged by: @aome510

Base: masterHead: fix-keybind


📝 Commits (1)

  • 310efe7 fix 0 key not working in popups

📊 Changes

1 file changed (+10 additions, -10 deletions)

View changed files

📝 spotify_player/src/event/popup.rs (+10 -10)

📄 Description

after #888 pressing 0 would always start the song over even in a popup.
hopefully this doesnt somehow break anyones config? it feels natural to me that the popup menu should take priority over other keybinds since the key is on display


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/911 **Author:** [@xdBronch](https://github.com/xdBronch) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/13/2026 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-keybind` --- ### 📝 Commits (1) - [`310efe7`](https://github.com/aome510/spotify-player/commit/310efe7aaae49e6928d8eb87f3e32c40e94ac082) fix `0` key not working in popups ### 📊 Changes **1 file changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/popup.rs` (+10 -10) </details> ### 📄 Description after #888 pressing 0 would always start the song over even in a popup. hopefully this doesnt somehow break anyones config? it feels natural to me that the popup menu should take priority over other keybinds since the key is on display --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:36:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1856
No description provided.