[PR #891] [MERGED] cleanup client API call codes #1847

New issue

Closed

opened 2026-03-14 15:36:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:36:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/891
Author: @aome510
Created: 12/22/2025
Status: ✅ Merged
Merged: 12/22/2025
Merged by: @aome510

Base: master ← Head: cleanup-client-call

📝 Commits (6)

6a0e3c6 upgrade deps
ae7e516 update how deref is used in client module
4e6d046 temporarily uses user client as the main Spotify client
d7b0450 update docs
2b29a94 update TODO
c2d4a92 update scopes for user-provided client

📊 Changes

5 files changed (+465 additions, -386 deletions)

View changed files

📝 Cargo.lock (+408 -336)
📝 spotify_player/Cargo.toml (+11 -11)
📝 spotify_player/src/auth.rs (+1 -1)
📝 spotify_player/src/client/mod.rs (+39 -15)
📝 spotify_player/src/client/spotify.rs (+6 -23)

📄 Description

Description of changes

temporarily use user-provided client instead of official Spotify client to make API calls
- this is a workaround for https://github.com/aome510/spotify-player/issues/890
upgrade dependencies
cleanup and update how deref is used in client codes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/891 **Author:** [@aome510](https://github.com/aome510) **Created:** 12/22/2025 **Status:** ✅ Merged **Merged:** 12/22/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `cleanup-client-call` --- ### 📝 Commits (6) - [`6a0e3c6`](https://github.com/aome510/spotify-player/commit/6a0e3c639d2d4eca157cb667e624eec4e3c1a14a) upgrade deps - [`ae7e516`](https://github.com/aome510/spotify-player/commit/ae7e516b34b54f2c49df8c73e470c4ba19cd5f7b) update how deref is used in client module - [`4e6d046`](https://github.com/aome510/spotify-player/commit/4e6d046c3c1f441bc90f5bdaecb47328fb9302ba) temporarily uses user client as the main Spotify client - [`d7b0450`](https://github.com/aome510/spotify-player/commit/d7b04505207e6970ada255d7008395520998b094) update docs - [`2b29a94`](https://github.com/aome510/spotify-player/commit/2b29a94c7521eec5e5982645d3abfdb0894fccf5) update TODO - [`c2d4a92`](https://github.com/aome510/spotify-player/commit/c2d4a92860499db689b44fdd29aead966f05e78b) update scopes for user-provided client ### 📊 Changes **5 files changed** (+465 additions, -386 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+408 -336) 📝 `spotify_player/Cargo.toml` (+11 -11) 📝 `spotify_player/src/auth.rs` (+1 -1) 📝 `spotify_player/src/client/mod.rs` (+39 -15) 📝 `spotify_player/src/client/spotify.rs` (+6 -23) </details> ### 📄 Description ## Description of changes - temporarily use user-provided client instead of official Spotify client to make API calls + this is a workaround for https://github.com/aome510/spotify-player/issues/890 - upgrade dependencies - cleanup and update how `deref` is used in client codes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>