[PR #871] [CLOSED] Context variable for playback format #1845

Closed
opened 2026-03-14 15:36:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/871
Author: @jtuzar
Created: 11/13/2025
Status: Closed

Base: masterHead: context-variable-for-playback-format


📝 Commits (5)

  • c9d5c87 wip without data fetching if the cache is not hit
  • 3bb80e6 prefetching of the context name
  • 0f1e7bf reduce nesting
  • 8d8f65d add ability to theme playback_context
  • d192f66 update docs

📊 Changes

4 files changed (+40 additions, -4 deletions)

View changed files

📝 docs/config.md (+2 -0)
📝 spotify_player/src/client/handlers.rs (+4 -0)
📝 spotify_player/src/config/theme.rs (+9 -0)
📝 spotify_player/src/ui/playback.rs (+25 -4)

📄 Description

This PR should resolve issue #626. It introduces new {context} variable to be used in the playback_format string.

Right now the variable is not able to determine the context name for app defined contexts.
github.com/aome510/spotify-player@6faa7803b1/spotify_player/src/state/model.rs (L59)

In order to get the context name even after the app freshly starts and resumes a previous playback the app needs to populate the context cache on playback event.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/871 **Author:** [@jtuzar](https://github.com/jtuzar) **Created:** 11/13/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `context-variable-for-playback-format` --- ### 📝 Commits (5) - [`c9d5c87`](https://github.com/aome510/spotify-player/commit/c9d5c873104d9f7ef96380d44268e3723702c1e0) wip without data fetching if the cache is not hit - [`3bb80e6`](https://github.com/aome510/spotify-player/commit/3bb80e6b22d2360f1725cfe607202eb2287e7069) prefetching of the context name - [`0f1e7bf`](https://github.com/aome510/spotify-player/commit/0f1e7bf2814464297798e5b6f6fa4e8dc0e53e6d) reduce nesting - [`8d8f65d`](https://github.com/aome510/spotify-player/commit/8d8f65d2a35f76bdfe37ef8eb243774da56934eb) add ability to theme playback_context - [`d192f66`](https://github.com/aome510/spotify-player/commit/d192f66470a8ff2597fc8b16282fdf13b2aa1995) update docs ### 📊 Changes **4 files changed** (+40 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/config.md` (+2 -0) 📝 `spotify_player/src/client/handlers.rs` (+4 -0) 📝 `spotify_player/src/config/theme.rs` (+9 -0) 📝 `spotify_player/src/ui/playback.rs` (+25 -4) </details> ### 📄 Description This PR should resolve issue #626. It introduces new {context} variable to be used in the playback_format string. Right now the variable is not able to determine the context name for app defined contexts. https://github.com/aome510/spotify-player/blob/6faa7803b1c5501096615a658291c08345b939b5/spotify_player/src/state/model.rs#L59 In order to get the context name even after the app freshly starts and resumes a previous playback the app needs to populate the context cache on playback event. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:36:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1845
No description provided.